Migrate all services to /data to persist them and their settings better

Move all services from `--user pi` to root to allow for reasonable ownership management between multiple OS instances

Add postflash service that validates that apt packages are properly installed

Fix small bug with LMS album art

Author: SteveMicroNova

amplipi/display/common.py

@@ -248,7 +248,7 @@ def get_status(url: str, no_serial_ok: bool = False, emoji: bool = True, max_len
     result_status = st
 
   # Check if API is running
-  api_on = subprocess.run("systemctl --user is-active amplipi.service".split(), stdout=subprocess.DEVNULL)
+  api_on = subprocess.run("systemctl is-active amplipi.service".split(), stdout=subprocess.DEVNULL)
   if api_on.returncode != 0:
     return DisplayError.NO_AMPLIPI_SERVICE, None, 0
 

amplipi/rt.py

@@ -283,6 +283,10 @@ def _recover_preamps(self) -> bool:
     try:
       self.reset_preamps()
       self.set_i2c_addr()
+      try:
+        self.bus.close()
+      except Exception:
+        pass
       self.bus = SMBus(1)
       for addr, regs in list(self.preamps.items()):
         for reg, val in enumerate(regs):
@@ -319,6 +323,10 @@ def write_byte_data(self, preamp_addr, reg, data):
         # Fallback 1: reopen the bus handle and retry (transient bus glitch).
         try:
           time.sleep(0.001)
+          try:
+            self.bus.close()
+          except Exception:
+            pass
           self.bus = SMBus(1)
           self.bus.write_byte_data(preamp_addr, reg, data)
         except Exception:

amplipi/updater/asgi.py

@@ -294,11 +294,14 @@ async def start_upload(file: UploadFile = File(...)):
 
 def download(url, file_name):
   """ Download a binary file from @url to @file_name """
+  # (connect timeout, read timeout) - read timeout is the max gap between
+  # received chunks, not a cap on total download time
+  response = requests.get(url, stream=True, timeout=(10, 30))
+  response.raise_for_status()
   with open(file_name, "wb") as file:
-    # get request
-    response = requests.get(url)
-    # write to file
-    file.write(response.content)
+    for chunk in response.iter_content(chunk_size=4 * 1024 * 1024):
+      if chunk:
+        file.write(chunk)
     # TODO: verify file has amplipi version
 
 
@@ -668,6 +671,7 @@ async def stream():
         # The section below used to be more pythonic by using with open(...) as f:, reading, and writing to the file
         # All of those operations require sudo privs due to touching a boot partition that doesn't belong to the root that's doing it
 
+      if manifest.boot is not None:
         yield {'data': json.dumps({'type': 'info', 'message': 'Patching cmdline.txt'})}
         content = subprocess.run(['sudo', 'cat', '/data/tmpmnt/cmdline.txt'], capture_output=True, text=True, check=True).stdout
         content = re.sub(rf'(root=PARTUUID=[0-9a-f]+-0){active_slot.value.root}\b', rf'\g<1>{target_slot.value.root}', content)

scripts/amplipi-postflash.service

@@ -0,0 +1,13 @@
+[Unit]
+Description=AmpliPi post-flash setup (package install and custom scripts)
+After=network-online.target
+Before=amplipi.service amplipi-tasks.service
+Wants=network-online.target
+
+[Service]
+Type=oneshot
+ExecStart=/usr/local/bin/amplipi-postflash.sh
+RemainAfterExit=yes
+
+[Install]
+WantedBy=multi-user.target

scripts/amplipi-postflash.sh

@@ -0,0 +1,43 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+PENDING_FILE="/boot/firmware/update-pending"
+PACKAGES_FILE="/data/packages.apt"
+SCRIPTS_DIR="/data/update_scripts"
+UPDATE_LOG="/data/update-log.txt"
+
+log() {
+  local msg="[$(date -Iseconds)] amplipi-postflash: $*"
+  echo "${msg}"
+  echo "${msg}" >> "${UPDATE_LOG}" 2>/dev/null || true
+}
+
+if [ ! -f "${PENDING_FILE}" ]; then
+  exit 0
+fi
+
+log "Trial boot detected — running post-flash setup"
+
+# Refresh apt package index (cleared during image prep to reduce image size)
+log "Refreshing apt package index..."
+apt-get update -qq || log "Warning: apt-get update failed — package installs may not work"
+
+# Install user-customized packages that need to survive OTA updates.
+# Add package names (one per line) to /data/packages.apt on p7.
+if [ -f "${PACKAGES_FILE}" ]; then
+  log "Installing packages from ${PACKAGES_FILE}..."
+  DEBIAN_FRONTEND=noninteractive xargs apt-get install -y < "${PACKAGES_FILE}" \
+    || log "Warning: some packages from ${PACKAGES_FILE} failed to install"
+fi
+
+# Run device-specific customization scripts from p7.
+# These survive OTA updates and are re-applied on each new slot's first boot.
+if [ -d "${SCRIPTS_DIR}" ]; then
+  for script in "${SCRIPTS_DIR}"/*.sh; do
+    [ -f "${script}" ] || continue
+    log "Running ${script}..."
+    bash "${script}" || log "Warning: ${script} exited non-zero"
+  done
+fi
+
+log "Post-flash setup complete"

scripts/amplipi-tryboot-verify.sh

@@ -70,9 +70,8 @@ log "Running health checks"
 
 failed_checks=()
 
-# TODO: switch to system services once services are moved off p7
-retry 12 5 systemctl --user -M pi@ is-active amplipi       || failed_checks+=("amplipi service")
-retry 12 5 systemctl --user -M pi@ is-active amplipi-tasks || failed_checks+=("amplipi-tasks service")
+retry 12 5 systemctl is-active amplipi       || failed_checks+=("amplipi service")
+retry 12 5 systemctl is-active amplipi-tasks || failed_checks+=("amplipi-tasks service")
 retry 6  5 systemctl is-active redis-server                || failed_checks+=("redis-server service")
 retry 12 5 curl -sf --max-time 5 http://localhost/api      || failed_checks+=("API health check")
 

scripts/cleanup

@@ -63,9 +63,9 @@ if ! ssh -o PasswordAuthentication=no $user_host 'echo "AmpliPi has your SSH Key
 fi
 
 echo -e "reverting amplipi back to stock configuration"
-ssh $user_host "systemctl --user stop amplipi"
+ssh $user_host "sudo systemctl stop amplipi"
 ssh $user_host "find /data/.config/amplipi -maxdepth 1 -type f -delete"  # intentionally avoids deleting folders used as mountpoints
-ssh $user_host "systemctl --user start amplipi"
+ssh $user_host "sudo systemctl start amplipi"
 
 echo -e "removing deployments"
 ssh $user_host "rm -rf amplipi-*.tar.gz amplipi-dev/amplipi-*"