make update process more rigorous

Author: rtertiaer

CHANGELOG.md

@@ -1,9 +1,11 @@
 # AmpliPi Software Releases
 
-## 0.4.5
+## Upcoming release
 * Web App
   * Ensure that abnormally-shaped album art is still horizontally centered
   * Add error handling on browser page for instances where the selected stream isn't browsable
+* System
+  * Make update process properly report errors
 
 ## 0.4.4
 * Web App

amplipi/updater/asgi.py

@@ -329,7 +329,8 @@ def request_support():
       '/opt/support_tunnel/venv/bin/python3 -m invoke request'.split(),
       capture_output=True,
       cwd='/opt/support_tunnel',
-      timeout=120
+      timeout=120,
+      check=True
     )
     return Response(content=f"{out.stdout.decode('utf')}", media_type="text/html")
   except Exception as e:

scripts/backup_config.sh

@@ -12,3 +12,4 @@ tar --one-file-system -czf "${backup_filename}" "${HOME}/.config/amplipi/"
 # remove all backups older than 90 days
 echo "removing old backups..."
 find "${backup_dir}" -type f -ctime +90 -delete
+echo "completed ${0}"

scripts/configure.py

@@ -1176,6 +1176,8 @@ def failed():
     pre_backup = _create_backup(env, "_pre-fw-upgrade")
     progress(pre_backup)
     tasks += pre_backup
+  if failed():
+    return False
   if os_deps:
     tasks += _install_os_deps(env, progress, _os_deps)
     if failed():
@@ -1221,6 +1223,8 @@ def failed():
     post_backup = _create_backup(env, "_post-fw-upgrade")
     progress(post_backup)
     tasks += post_backup
+  if failed():
+    return False
   if restart_updater:
     # Reboot OS to finish potential kernel upgrade, also restarting the updater
     progress([Task('Reboot os', success=True)])