Internet Radio Search Fix#1060
Conversation
| let servers = fetch("https://all.api.radio-browser.info/json/servers", { | ||
| method: "POST", | ||
| headers: { "Content-Type": "application/json" }, | ||
| body: JSON.stringify({ name }), | ||
| }).then(r => r.json()); |
There was a problem hiding this comment.
There's some potential where this is a race condition but truthfully if you manage to select the textbox, type a valid search, and hit enter within .3 seconds of the dialog box opening (the average time this request takes to resolve on my computer) then that's on you
| setHasError(true); | ||
| return; | ||
| } | ||
| // Check if all required fields are filled |
There was a problem hiding this comment.
This mixes formatting changes with code changes, making it hard to figure out what changed. Could you put the formatting changes in a separate commit next time?
There was a problem hiding this comment.
Hide whitespace changes works around this for now.
|
As discussed IRL I'm wondering what the network traffic looks like when you open up the search tab and when you search. I would hope that we can optimize the load we add to to these amazing free services. |
SteveMicroNova
force-pushed
the
InternetRadioSearchFix2
branch
from
08db6bf to
c18d51c
Compare
SteveMicroNova
force-pushed
the
InternetRadioSearchFix2
branch
from
c18d51c to
a92746a
Compare
SteveMicroNova
force-pushed
the
InternetRadioSearchFix2
branch
from
21cabfb to
3adf30c
Compare
linknum23
left a comment
linknum23
left a comment
There was a problem hiding this comment.
Looks good. NOTE that the CHANGELOG will need to be fixed up.
2 participants
What does this change intend to accomplish?
The same as #1057 but good and useful
Checklist
./scripts/test