Volume Delta Expansion#1062
Conversation
|
This has expanded to also include #1024 due to that being one extra line beyond what I'd already done to implement that for zones, though I then discovered it was an extra chunk to App.jsx to do the same for groups so there was some slight feature creep to this PR there. |
0bb2671 to
31dc4ab
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 50.67% 50.25% -0.42%
==========================================
Files 40 41 +1
Lines 7154 7368 +214
==========================================
+ Hits 3625 3703 +78
- Misses 3529 3665 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This does not interfere with home assistant's functionality |
b2379f0 to
eea75bb
Compare
db7f047 to
54fda80
Compare
94e796e to
f067d19
Compare
linknum23
left a comment
There was a problem hiding this comment.
The changes here look pretty reasonable. As this is an API change we should add one or more tests (or update pre-existing ones) right?
8888e3c to
6fc3b89
Compare
|
There's some jittering in this yet, not due to this PR but exacerbated by it. The origin of this jitter is that we send volume change requests while sliding the slider but not all of the delta is always realized during that due to a race condition. A few solutions to this:
There's also some potential that the jitter is due to javascript only having floats for decimal values, which would mean we have to fix this by rounding every single instance of a float vol everywhere to see this fixed |
1e75bbc to
f92f5c5
Compare
013587a to
9efc33d
Compare
9efc33d to
5d5e3f2
Compare
f91af7e to
5cf41be
Compare
What does this change intend to accomplish?
This PR aims to preserve the relative distance between zone volume levels when they would otherwise exceed the min or max vol_f
Demonstration
Checklist
./scripts/test