fix(web): preserve player metadata width#1105
Conversation
|
I haven't got a good environment to test this at the moment but based on how similar this looks to #1104, I assume the failure points of #1104 still stand There should be a few chunks of CSS spread out in various places that actually overwrite what you've done here, see my comments on that other PR to see what those CSS chunks do to overwrite the classes you've made Note that this is based purely on looking at the code and not from actually seeing an issue, so don't feel like you need to dig too deep on this until I have time to test properly. If you'd like to test in lieu of having a unit to test on, we offer scripts such as run_debug_backend and run_debug_frontend in our scripts folder that can be run at the same time to simulate a full AmpliPi unit for testing. |
What does this change intend to accomplish?
Fixes #1103.
When album art is missing or fails to load, the image has no intrinsic size and the player metadata column collapses. This change reserves a square album-art area so song, album, and artist metadata retain a stable width:
The metadata Grid now uses a class instead of an inline max-width so the responsive rules live in the stylesheet.
Validation
The build passed. npm ci reported the repository's existing dependency audit findings (1 low, 9 moderate, 11 high). Cross-browser manual testing was not available in this environment.