Skip to content

fix: move stepTimeoutDuration to work as expected #94

Closed
SLopez96 wants to merge 1 commit into
microblink:masterfrom
SLopez96:fix-stepTimeoutDuration
Closed

fix: move stepTimeoutDuration to work as expected #94
SLopez96 wants to merge 1 commit into
microblink:masterfrom
SLopez96:fix-stepTimeoutDuration

Conversation

@SLopez96

Copy link
Copy Markdown

Problem

During implementation of the Flutter BlinkID package, I noticed that the stepTimeoutDuration parameter had no effect on the actual timeout behavior. After debugging the Kotlin source files, I discovered that the timeout value was being incorrectly passed to BlinkIdSessionSettings instead of BlinkIdScanningUxSettings where it's actually used.

Solution

Moved stepTimeoutDuration from BlinkIdSessionSettings to BlinkIdScanningUxSettings in the Dart layer
Updated the automatically generated file

Testing

✅ Android: Verified working in my Flutter application
⚠️ iOS: Untested (no access to iOS development environment)

This change ensures the timeout parameter works as expected across platforms. Would appreciate if someone could verify the iOS implementation.

@SandraZiv

Copy link
Copy Markdown
Contributor

Hi 👋 Thanks for submitting a fix!

We've already fixed this on master in the Android bridge instead of moving the Dart API: session timeouts are mapped into UX settings in BlinkidDeserializationUtils.kt, while iOS continues to read them from session settings in BlinkIdDeserializationUtils.swift. That keeps one cross-platform API, ie the timeouts are in BlinkIdSessionSettings for both platforms

BlinkIdSessionSettings(
  stepTimeoutDuration: 60000,
  inactivityTimeoutDuration: 10000,
  // ...
)

This also applies to the new inactivityTimeoutDuration.

Closing the PR. If you find any other problems, please open a new issue or PR.

@SandraZiv SandraZiv closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants