Merge pull request #464 from aniket866/fix/Nil-Pointer-Dereference

fix (cmd,pkg) : Potential Panic/Crash via Nil Pointer Dereference in Switch Context Command

Author: Harsh4902

cmd/context.go

@@ -47,6 +47,7 @@ microcks context http://localhost:8080 --delete`,
 			}
 
 			ctxName := args[0]
+			errors.CheckConfigNil(localCfg == nil, configPath)
 			if localCfg.CurrentContext == ctxName {
 				fmt.Printf("Already at context '%s'\n", localCfg.CurrentContext)
 				return
@@ -100,9 +101,7 @@ func deleteContext(context, configPath string) error {
 func printMicrocksContexts(configPath string) {
 	localCfg, err := config.ReadLocalConfig(configPath)
 	errors.CheckError(err)
-	if localCfg == nil {
-		log.Fatalf("No contexts defined in %s", configPath)
-	}
+	errors.CheckConfigNil(localCfg == nil, configPath)
 	w := tabwriter.NewWriter(os.Stdout, 0, 0, 2, ' ', 0)
 	defer func() { _ = w.Flush() }()
 	columnNames := []string{"CURRENT", "NAME", "SERVER"}

cmd/context_test.go

@@ -64,3 +64,9 @@ func TestDeleteContext(t *testing.T) {
 	_, err = config.ReadLocalConfig(testConfigFilePath)
 	require.NoError(t, err)
 }
+
+func TestDeleteContextEmpty(t *testing.T) {
+	err := deleteContext("http://localhost:8080", "./testdata/non-existent-file.config")
+	require.EqualError(t, err, "Nothing to logout from")
+}
+

pkg/errors/error.go

@@ -24,6 +24,13 @@ func CheckError(err error) {
 	}
 }
 
+func CheckConfigNil(isNil bool, path string) {
+	if isNil {
+		Fatal(ErrorGeneric, "No contexts defined in "+path)
+	}
+}
+
+
 // Fatal is a wrapper for log.Fatal() to exit with custom code
 func Fatal(exitcode int, args ...interface{}) {
 	log.Println(args...)