refine shell completion command

Signed-off-by: puneeth_aditya_5656 <myakampuneeth@gmail.com>

Author: mugiwaraluffy56

cmd/completion.go

@@ -16,8 +16,6 @@
 package cmd
 
 import (
-	"fmt"
-
 	"github.com/microcks/microcks-cli/pkg/errors"
 	"github.com/spf13/cobra"
 )
@@ -27,7 +25,13 @@ func NewCompletionCommand() *cobra.Command {
 		Use:   "completion [bash|zsh|fish|powershell]",
 		Short: "Generate shell completion scripts",
 		Long:  `Generate shell completion scripts`,
-		Args:  cobra.ExactArgs(1),
+		Args:  cobra.MatchAll(cobra.ExactArgs(1), cobra.OnlyValidArgs),
+		ValidArgs: []string{
+			"bash",
+			"zsh",
+			"fish",
+			"powershell",
+		},
 		Run: func(cmd *cobra.Command, args []string) {
 			rootCmd := cmd.Root()
 			var err error
@@ -41,8 +45,6 @@ func NewCompletionCommand() *cobra.Command {
 				err = rootCmd.GenFishCompletion(cmd.OutOrStdout(), true)
 			case "powershell":
 				err = rootCmd.GenPowerShellCompletion(cmd.OutOrStdout())
-			default:
-				err = fmt.Errorf("unsupported shell %q", args[0])
 			}
 			errors.CheckError(err)
 		},

cmd/completion_test.go

@@ -36,3 +36,16 @@ func TestCompletionCommandGeneratesBash(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Contains(t, buf.String(), "completion for microcks")
 }
+
+func TestCompletionCommandRejectsUnsupportedShell(t *testing.T) {
+	cmd := NewCommad()
+	buf := &bytes.Buffer{}
+	cmd.SetOut(buf)
+	cmd.SetErr(buf)
+	cmd.SetArgs([]string{"completion", "nushell"})
+
+	err := cmd.Execute()
+
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "invalid argument")
+}

documentation/cmd/completion.md

@@ -1,13 +1,12 @@
-## `microcks completion` - Generate shell completion scripts
-
-Generates shell completion scripts for supported shells.
+## `microcks completion` – Generate Shell Completion Scripts
+Generates shell completion scripts for bash, zsh, fish, and PowerShell.
 
 ### Usage
 ```bash
 microcks completion [bash|zsh|fish|powershell]
 ```
 
-### Examples
+### Example
 ```bash
 # Generate bash completion
 microcks completion bash