Skip to content

Commit a696dc6

Browse files
fix: replace silent return with os.Exit(1) on auth/config failures
Commands cmd/test.go, cmd/import.go, cmd/importDir.go, and cmd/importURL.go used plain return statements inside error branches (config read failure, nil localConfig, NewClient failure). Because Cobra treats a normal Run return as success, the process exited with status 0, causing CI/CD pipelines to report false-positive success. Replace every such return with os.Exit(1) so that: - missing/corrupt config file → exit 1 - missing login session (localConfig == nil) → exit 1 - client initialisation failure (NewClient) → exit 1 - ValidationError from ImportDirectory → exit 1 No user-visible messages were changed. Fixes #361 Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
1 parent b12c047 commit a696dc6

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

cmd/import.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func NewImportCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command
5555
localConfig, err := config.ReadLocalConfig(globalClientOpts.ConfigPath)
5656
if err != nil {
5757
fmt.Println(err)
58-
return
58+
os.Exit(1)
5959
}
6060

6161
// Prepare Microcks client.
@@ -101,7 +101,7 @@ func NewImportCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command
101101
// Create client from config file and using the current or provided context.
102102
if localConfig == nil {
103103
fmt.Println("Please login to perform operation...")
104-
return
104+
os.Exit(1)
105105
}
106106

107107
if globalClientOpts.Context == "" {
@@ -111,7 +111,7 @@ func NewImportCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command
111111
mc, err = connectors.NewClient(*globalClientOpts)
112112
if err != nil {
113113
fmt.Printf("error %v", err)
114-
return
114+
os.Exit(1)
115115
}
116116
}
117117

cmd/importDir.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,12 @@ func NewImportDirCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
131131
localConfig, err := config.ReadLocalConfig(globalClientOpts.ConfigPath)
132132
if err != nil {
133133
fmt.Println(err)
134-
return
134+
os.Exit(1)
135135
}
136136

137137
if localConfig == nil {
138138
fmt.Println("Please login to perform operation...")
139-
return
139+
os.Exit(1)
140140
}
141141

142142
if globalClientOpts.Context == "" {
@@ -147,7 +147,7 @@ func NewImportDirCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
147147
mc, err := connectors.NewClient(*globalClientOpts)
148148
if err != nil {
149149
fmt.Printf("error %v", err)
150-
return
150+
os.Exit(1)
151151
}
152152

153153
// Set up business logic dependencies
@@ -163,7 +163,7 @@ func NewImportDirCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
163163
if err != nil {
164164
if validationErr, ok := err.(*ValidationError); ok {
165165
fmt.Println(validationErr.Message)
166-
return
166+
os.Exit(1)
167167
}
168168
fmt.Printf("Error: %v\n", err)
169169
os.Exit(1)

cmd/importURL.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@ func NewImportURLCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
7777
localConfig, err := config.ReadLocalConfig(globalClientOpts.ConfigPath)
7878
if err != nil {
7979
fmt.Println(err)
80-
return
80+
os.Exit(1)
8181
}
8282

8383
if localConfig == nil {
8484
fmt.Println("Please login to perform operation...")
85-
return
85+
os.Exit(1)
8686
}
8787

8888
if globalClientOpts.Context == "" {
@@ -92,7 +92,7 @@ func NewImportURLCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
9292
mc, err = connectors.NewClient(*globalClientOpts)
9393
if err != nil {
9494
fmt.Printf("error %v", err)
95-
return
95+
os.Exit(1)
9696
}
9797
}
9898
sepSpecificationFiles := strings.Split(specificationFiles, ",")

cmd/test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,12 @@ func NewTestCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
145145
localConfig, err := config.ReadLocalConfig(globalClientOpts.ConfigPath)
146146
if err != nil {
147147
fmt.Println(err)
148-
return
148+
os.Exit(1)
149149
}
150150

151151
if localConfig == nil {
152152
fmt.Println("Please login to perform operation...")
153-
return
153+
os.Exit(1)
154154
}
155155

156156
if globalClientOpts.Context == "" {
@@ -160,7 +160,7 @@ func NewTestCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
160160
mc, err = connectors.NewClient(*globalClientOpts)
161161
if err != nil {
162162
fmt.Printf("error %v", err)
163-
return
163+
os.Exit(1)
164164
}
165165

166166
ctx, err := localConfig.ResolveContext(globalClientOpts.Context)

0 commit comments

Comments
 (0)