fix: return error from json.Unmarshal in GetTestResult instead of ignoring it (#258)

mugiwaraluffy56 · web-flow · commit f9f232cd0633 · 2026-05-04T14:03:23.000+02:00
Signed-off-by: puneeth_aditya_5656 &lt;myakampuneeth@gmail.com&gt;
diff --git a/pkg/connectors/microcks_client.go b/pkg/connectors/microcks_client.go
@@ -410,9 +410,11 @@ func (c *microcksClient) GetTestResult(testResultID string) (*TestResultSummary,
 	}
 
 	result := TestResultSummary{}
-	json.Unmarshal([]byte(body), &result)
+	if err := json.Unmarshal(body, &result); err != nil {
+		return nil, fmt.Errorf("failed to parse test result response: %w", err)
+	}
 
-	return &result, err
+	return &result, nil
 }
 
 func (c *microcksClient) UploadArtifact(specificationFilePath string, mainArtifact bool) (string, error) {

Original file line number	Diff line number	Diff line change
`@@ -410,9 +410,11 @@ func (c microcksClient) GetTestResult(testResultID string) (TestResultSummary,`
`410`	`410`	`}`
`411`	`411`
`412`	`412`	`result := TestResultSummary{}`
`413`		`- json.Unmarshal([]byte(body), &result)`
	`413`	`+ if err := json.Unmarshal(body, &result); err != nil {`
	`414`	`+ return nil, fmt.Errorf("failed to parse test result response: %w", err)`
	`415`	`+ }`
`414`	`416`
`415`		`- return &result, err`
	`417`	`+ return &result, nil`
`416`	`418`	`}`
`417`	`419`
`418`	`420`	`func (c *microcksClient) UploadArtifact(specificationFilePath string, mainArtifact bool) (string, error) {`