fix: stream multipart upload in UploadArtifact to avoid unbounded mem…#372
Merged
Harsh4902 merged 1 commit intoMay 14, 2026
Merged
Conversation
…ory allocation Replace bytes.Buffer with io.Pipe() in UploadArtifact so multipart form data is streamed directly from disk to the HTTP request. This keeps memory usage constant regardless of artifact file size, preventing OOM kills on constrained CI/CD runners. Also replaces panic() calls with proper error returns in the upload path. Fixes microcks#324 Signed-off-by: abhaygoudannavar <abhaysgoudnvr@gmail.com>
abhaygoudannavar
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
Contributor
Author
|
@Harsh4902 i worked on #324 any changes is needed in the pr? |
Harsh4902
approved these changes
May 14, 2026
Member
Harsh4902
left a comment
Harsh4902
left a comment
There was a problem hiding this comment.
Thanks @abhaygoudannavar for this contribution. LGTM
|
You are now a Microcks community contributor! 💖 Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏 📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌" Kudos and please keep going, we need you 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bytes.Bufferwithio.Pipe()streaming inUploadArtifact(pkg/connectors/microcks_client.go). Multipart form data is now written in a background goroutine and streamed directly from disk to the HTTP request, keeping memory usage constant regardless of artifact file size.panic()calls with properfmt.Errorferror returns in the upload path, matching the style of recent fixes (e.g.,f9f282c).TestUploadArtifactStreamsWithoutBufferingtest (pkg/connectors/microcks_client_test.go) covering file content integrity, filename,mainArtifactfield, and HTTP response handling.Test results:
$ go test ./pkg/connectors/... ok github.com/microcks/microcks-cli/pkg/connectors 0.022s
Related issue(s)
Fixes #324