more small changes to start behaviour

- fix uncaught promise rejection
- fix inaccurate logging
- ping environment until it comes up

Author: Tim Etchells

dev/src/command/ActivateConnectionCmd.ts

@@ -82,10 +82,35 @@ async function tryAddConnection(connInfo: MCUtil.IConnectionInfo): Promise<Conne
     try {
         try {
             envData = await MCEnvironment.getEnvData(url);
+            Log.d("Initial connect succeeded, no need to start Codewind");
         }
         catch (err) {
             await InstallerWrapper.start();
-            envData = await MCEnvironment.getEnvData(url);
+
+            Log.d("Codewind should have started, pinging for ENV data now...");
+            envData = await new Promise<MCEnvironment.IMCEnvData>((resolve, reject) => {
+                let tries = 0;
+                const interval = setInterval(() => {
+                    tries++;
+
+                    MCEnvironment.getEnvData(url)
+                    .then((envData_) => {
+                        // success
+                        Log.i(`Connected to codewind after ${tries} tries`);
+                        clearInterval(interval);
+                        return resolve(envData_);
+                    })
+                    .catch((_err) => {
+                        if (tries > 10) {
+                            clearInterval(interval);
+                            return reject("Codewind appeared to start, but connecting failed.");
+                        }
+                        else {
+                            Log.d("Failed to contact codewind, will try again");
+                        }
+                     });
+                }, 500);
+            });
         }
     }
     catch (err) {

dev/src/microclimate/connection/Connection.ts

@@ -105,7 +105,12 @@ export default class Connection implements vscode.QuickPickItem, vscode.Disposab
         this.hasConnected = true;
         this._isConnected = true;
         Log.d(`${this} is now connected`);
-        await this.forceUpdateProjectList();
+        try {
+            await this.forceUpdateProjectList();
+        }
+        catch (err) {
+            Log.e("Error getting projects list after connect event", err)
+        }
 
         this.onChange();
     }

dev/src/microclimate/connection/InstallerWrapper.ts

@@ -84,6 +84,8 @@ namespace InstallerWrapper {
             return;
         }
 
+        Log.i(`Running installer command: ${cmd}`);
+
         const userMsg = getUserActionName(cmd) + "...";
         currentOperation = cmd;
 
@@ -98,22 +100,16 @@ namespace InstallerWrapper {
                     timeout: START_TIMEOUT,
                 }, async (err, stdout, stderr) => {
                     if (err) {
-                        Log.e("Error starting with installer", err);
+                        Log.e("Error running with installer", err);
                         Log.e("Stdout:", stdout.toString());
                         Log.e("Stderr:", stderr.toString());
                         currentOperation = undefined;
                         return reject(err);
                     }
-                    Log.i("Successfully started CW with installer");
-
-                    // if (cmd === InstallerCommands.START) {
-                    //     // additional delay
-                    //     await new Promise((resolve2) => setTimeout(resolve2, 5000));
-                    // }
+                    Log.i(`Successfully ran installer command: ${cmd}`);
 
                     currentOperation = undefined;
                     resolve();
-                    Log.d("Finished starting Codewind");
                 });
             });
         });