helpers: apply id and lang attr regexps to full string#198
Open
matloob wants to merge 1 commit into
Open
Conversation
The intent of the code seemed to be to allow ids and langs where the full string matches the regular expression, not just part of it.
diasbruno
reviewed
Sep 9, 2024
| p.AllowAttrs( | ||
| "lang", | ||
| ).Matching(regexp.MustCompile(`[a-zA-Z]{2,20}`)).Globally() | ||
| ).Matching(regexp.MustCompile(`^[a-zA-Z]{2,20}$`)).Globally() |
There was a problem hiding this comment.
ˆ and $ can be abused by attackers. Check if it's possible to use \A or \z.
Example: \A[a-zA-Z]{2,20}\z
Author
There was a problem hiding this comment.
I think this is fine? Unless the ?m flag is provided, ^ and $ match the beginning and end of the text, not the beginning and end of the line. (See https://pkg.go.dev/regexp/syntax)
There was a problem hiding this comment.
Nice. So just need to guarantee that the flag is enabled.
Author
There was a problem hiding this comment.
Hi do you mean for us to add a test to ensure that the ?m flag is not used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of the code seemed to be to allow ids and langs where the full string matches the regular expression, not just part of it.