Skip to content

Commit cce6cb1

Browse files
committed
fix: reuse underlying HttpClient in toBlocking()
DefaultJdkHttpClient.toBlocking() now constructs JdkBlockingHttpClient via the existing AbstractJdkHttpClient prototype copy constructor sharing the underlying java.net.http.HttpClient
1 parent 04b8ebe commit cce6cb1

2 files changed

Lines changed: 4 additions & 15 deletions

File tree

http-client-jdk/src/main/java/io/micronaut/http/client/jdk/DefaultJdkHttpClient.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -145,21 +145,7 @@ private static MediaTypeCodecRegistry createDefaultMediaTypeRegistry() {
145145

146146
@Override
147147
public BlockingHttpClient toBlocking() {
148-
return new JdkBlockingHttpClient(
149-
loadBalancer,
150-
httpVersion,
151-
configuration,
152-
contextPath,
153-
filterResolver,
154-
clientFilterEntries,
155-
mediaTypeCodecRegistry,
156-
messageBodyHandlerRegistry,
157-
requestBinderRegistry,
158-
clientId,
159-
conversionService,
160-
sslBuilder,
161-
cookieDecoder
162-
);
148+
return new JdkBlockingHttpClient(this);
163149
}
164150

165151
@Override

http-client-jdk/src/main/java/io/micronaut/http/client/jdk/JdkBlockingHttpClient.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@
4444
@Internal
4545
@Experimental
4646
public class JdkBlockingHttpClient extends AbstractJdkHttpClient implements BlockingHttpClient {
47+
JdkBlockingHttpClient(AbstractJdkHttpClient prototype) {
48+
super(prototype);
49+
}
4750

4851
public JdkBlockingHttpClient(
4952
LoadBalancer loadBalancer,

0 commit comments

Comments
 (0)