fix: use Http2ClientConfiguration.PREFIX for ServiceHttp2ClientConfiguration#12625
Open
funsaized wants to merge 1 commit into
Open
Conversation
|
|
…uration
The `@ConfigurationProperties` annotation on `ServiceHttp2ClientConfiguration`
was referencing `WebSocketCompressionConfiguration.PREFIX` ("ws.compression")
instead of `Http2ClientConfiguration.PREFIX` ("http2"), likely a copy-paste
error from the adjacent `ServiceWebSocketCompressionConfiguration` class.
This caused the nested HTTP/2 client configuration for per-service clients
(`micronaut.http.services.<name>.http2.*`) to bind under the wrong property
path and collide with the WebSocket compression configuration prefix.
Fixes micronaut-projects#12620
funsaized
force-pushed
the
fix/service-http2-configuration-properties-prefix
branch
from
d6c105a to
20ef268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@ConfigurationPropertiesannotation onServiceHttp2ClientConfiguration(a nested class insideServiceHttpClientConfiguration) was referencingWebSocketCompressionConfiguration.PREFIX("ws.compression") instead ofHttp2ClientConfiguration.PREFIX("http2").This appears to be a copy-paste slip from the adjacent
ServiceWebSocketCompressionConfigurationclass, and causes the nested HTTP/2 client configuration for per-service clients to bind under the wrong property path (and collide with the WebSocket compression configuration prefix).Change
This aligns
ServiceHttp2ClientConfigurationwith its parent classHttp2ClientConfiguration(PREFIX = "http2"), consistent with how the sibling pool/compression/ssl nested configurations use their respective parent-class prefixes.Reference
Fixes #12620