fix #12651: reuse underlying HttpClient in toBlocking() to prevent thread leak [backport 4.10.x]#12653
Open
naborka wants to merge 3 commits into
Open
Conversation
DefaultJdkHttpClient.toBlocking() now constructs JdkBlockingHttpClient via the existing AbstractJdkHttpClient prototype copy constructor sharing the underlying java.net.http.HttpClient
naborka
force-pushed
the
backport/jdk-toblocking-fix-4.10.x
branch
from
740f5e7 to
cce6cb1
Compare
Contributor
|
thanks @naborka are all the changes backported here? |
Contributor
Author
|
@graemerocher yes, the same cherrypicked onto the 4.10.x base #12652 commits are present here, both fail spec tests and the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12652 to
4.10.x.Fixes #12651
Problem
DefaultJdkHttpClient.toBlocking()constructs newJdkBlockingHttpClient+ newjava.net.http.HttpClienton every callHttpClientspawns threads and under sync declarative@Clientload threads accumulate without bound causing OOMKillsFix
JdkBlockingHttpClientdelegating toAbstractJdkHttpClient(AbstractJdkHttpClient prototype)toBlocking()now callsnew JdkBlockingHttpClient(this)and shares existingHttpClientand threadsThis mirrors pattern in
JdkRawHttpClient