lsm6dsox: Consolidate getters and setters into config function.

Signed-off-by: Sebastian Romero <s.romero@arduino.cc>

Author: sebromero

micropython/drivers/imu/lsm6dsox/lsm6dsox.py

@@ -319,68 +319,38 @@ def mlc_output(self):
             self.set_mem_bank(_FUNC_CFG_BANK_USER)
         return buf
 
-    @property
-    def pedometer_enabled(self):
-        """Whether the pedometer feature is enabled."""
-        self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
-        data = self._read_reg(_EMB_FUNC_EN_A)
-        self.set_mem_bank(_FUNC_CFG_BANK_USER)
-        return bool(data & _PEDO_EN_MASK)
+    def pedometer_config(self, enable=True, debounce=10, int1_enable=False, int2_enable=False):
+        """Configure the pedometer features."""
+        self._select_page(_PEDO_DEB_STEPS_CONF, debounce)
+
+        if int1_enable:
+            self._set_bits(_MD1_CFG, _INT_EMB_FUNC_MASK)
+        if int2_enable:
+            self._set_bits(_MD2_CFG, _INT_EMB_FUNC_MASK)
 
-    @pedometer_enabled.setter
-    def pedometer_enabled(self, enable):
-        """Enable or disable the pedometer feature."""
         self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
+
         if enable:
             self._set_bits(_EMB_FUNC_EN_A, _PEDO_EN_MASK)
         else:
             self._clear_bits(_EMB_FUNC_EN_A, _PEDO_EN_MASK)
-        self.set_mem_bank(_FUNC_CFG_BANK_USER)
 
-    def pedometer_reset(self):
-        """Reset the step counter."""
-        self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
-        self._set_bits(_EMB_FUNC_SRC, _PEDO_RST_STEP_MASK)
-        self.set_mem_bank(_FUNC_CFG_BANK_USER)
-
-    @property
-    def pedometer_int1_enabled(self):
-        """Whether step detection interrupt is routed to INT1 pin."""
-        self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
-        data = self._read_reg(_EMB_FUNC_INT1)
-        self.set_mem_bank(_FUNC_CFG_BANK_USER)
-        return bool(data & _PEDO_INT_MASK)
-
-    @pedometer_int1_enabled.setter
-    def pedometer_int1_enabled(self, enable):
-        """Route step detection interrupt to INT1 pin."""
-        if enable:
-            self._set_bits(_MD1_CFG, _INT_EMB_FUNC_MASK)
-            self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
+        if int1_enable:
             self._set_bits(_EMB_FUNC_INT1, _PEDO_INT_MASK)
         else:
-            self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
             self._clear_bits(_EMB_FUNC_INT1, _PEDO_INT_MASK)
-        self.set_mem_bank(_FUNC_CFG_BANK_USER)
-
-    @property
-    def pedometer_int2_enabled(self):
-        """Whether step detection interrupt is routed to INT2 pin."""
-        self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
-        data = self._read_reg(_EMB_FUNC_INT2)
-        self.set_mem_bank(_FUNC_CFG_BANK_USER)
-        return bool(data & _PEDO_INT_MASK)
 
-    @pedometer_int2_enabled.setter
-    def pedometer_int2_enabled(self, enable):
-        """Route step detection interrupt to INT2 pin."""
-        if enable:
-            self._set_bits(_MD2_CFG, _INT_EMB_FUNC_MASK)
-            self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
+        if int2_enable:
             self._set_bits(_EMB_FUNC_INT2, _PEDO_INT_MASK)
         else:
-            self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
             self._clear_bits(_EMB_FUNC_INT2, _PEDO_INT_MASK)
+
+        self.set_mem_bank(_FUNC_CFG_BANK_USER)
+
+    def pedometer_reset(self):
+        """Reset the step counter."""
+        self.set_mem_bank(_FUNC_CFG_BANK_EMBED)
+        self._set_bits(_EMB_FUNC_SRC, _PEDO_RST_STEP_MASK)
         self.set_mem_bank(_FUNC_CFG_BANK_USER)
 
     def steps(self):
@@ -390,16 +360,6 @@ def steps(self):
         self.set_mem_bank(_FUNC_CFG_BANK_USER)
         return self.scratch_2b[0] | (self.scratch_2b[1] << 8)
 
-    @property
-    def pedometer_debounce_steps(self):
-        """Get the pedometer debounce steps."""
-        return self._select_page(_PEDO_DEB_STEPS_CONF)
-
-    @pedometer_debounce_steps.setter
-    def pedometer_debounce_steps(self, steps):
-        """Set the pedometer debounce steps. Default is 10."""
-        self._select_page(_PEDO_DEB_STEPS_CONF, steps)
-
     def gyro(self):
         """Returns gyroscope vector in degrees/sec."""
         mv = memoryview(self.scratch_int)

micropython/drivers/imu/lsm6dsox/lsm6dsox_pedometer.py

@@ -17,30 +17,27 @@
 # Or init in SPI mode.
 # lsm = LSM6DSOX(SPI(5), cs=Pin(10))
 
-# Enable the pedometer feature.
-lsm.pedometer_enabled = True
-
-# Set debounce steps to 5 (default is 10).
-# This means that after a step is detected, the pedometer will ignore any new steps for the next 5 step detections.
-# This can help to filter out false positives and improve step counting accuracy.
-lsm.pedometer_debounce_steps = 5
-
-# Enable interrupts for step detection on both INT1 and INT2 pins.
-lsm.pedometer_int1_enabled = True
-lsm.pedometer_int2_enabled = True
+# Enable the pedometer feature, set debounce steps to 5, and enable interrupts on both INT1 and INT2.
+# Default debounce steps is 10. This means that after a step is detected, the pedometer
+# will ignore any new steps for the next 5 step detections. This can help to filter out
+# false positives and improve step counting accuracy.
+# If you just want to enable the pedometer, simply call lsm.pedometer_config(enable=True).
+lsm.pedometer_config(debounce=5, int1_enable=True, int2_enable=True)
 
 # Register interrupt handler on a Pin. e.g. D8
+# The interrupt pins are open-drain, so they will be pulled low when a step is detected.
+# We configure the host pin with a pull-up resistor to ensure it stays high when not active.
 interrupt_pin = Pin("D8", Pin.IN, Pin.PULL_UP)
 
 
 def on_step_detected(pin):
-    print("Step detected!")
+    print("Steps detected!")
 
 
 # Configure the interrupt pin to trigger on falling edge (active low) when a step is detected.
 interrupt_pin.irq(trigger=Pin.IRQ_FALLING, handler=on_step_detected)
 
-last_steps = 0  # Keep track of the last step count to detect changes.
+last_steps = None  # Keep track of the last step count to detect changes.
 
 while True:
     steps = lsm.steps()