aioble: Raise correct error if l2cap disconnects in middle of send.#1006
Merged
dpgeorge merged 1 commit intomicropython:masterfrom Jun 24, 2025
Merged
Conversation
andrewleech
force-pushed
the
aioble_l2cap_send_disconnect
branch
from
7e1c9cf to
a3bd39d
Compare
dpgeorge
reviewed
Jun 24, 2025
andrewleech
force-pushed
the
aioble_l2cap_send_disconnect
branch
from
a3bd39d to
b394623
Compare
dpgeorge
approved these changes
Jun 24, 2025
If BLE disconnects in the middle of a send process, this change makes the code raise `L2CAPDisconnectedError` rather than `TypeError` due to `_cid` being `None`. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
dpgeorge
force-pushed
the
aioble_l2cap_send_disconnect
branch
from
b394623 to
913498e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using aioble/l2cap to send data from micropython to a cental like a phone, if the ble disconnects in the middle of a send process it can currently fail with the exception:
This is because the send function is operating in a loop sending the data in chunks.
At the top of the function
self._assert_connected()is already called which will raise aL2CAPDisconnectedErrorif the connection has already been dropped (as detected byself._cid is Nonehowever the chunk send loop can run for some time, a disconnect in the middle of this results inself._cid = Nonebeing passed toble.l2cap_send()resulting in the exception above.This PR simply adds the correct connection check immediately before each loop of
l2cap_send().