Skip to content

aioble/server: Log warning on out-of-order indication. #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewleech wants to merge 2 commits into
base: master
Choose a base branch
from
Open

aioble/server: Log warning on out-of-order indication. #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
916b9e1
aioble/server: Log warning on out-of-order indication.
pi-anl Aug 17, 2021
b9e7feb
aioble/server: Guard _indicate_done against non-indicate characteristics
pi-anl Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions micropython/bluetooth/aioble/aioble/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,19 @@ async def indicate(self, connection, data=None, timeout_ms=1000):

def _indicate_done(conn_handle, value_handle, status):
if characteristic := _registered_characteristics.get(value_handle, None):
if not (characteristic.flags & _FLAG_INDICATE):
log_warn("Received indication on unexpected characteristic:", value_handle)
return
if connection := DeviceConnection._connected.get(conn_handle, None):
if not characteristic._indicate_connection:
# Timeout.
return
# See TODO in __init__ to support multiple concurrent indications.
assert connection == characteristic._indicate_connection
characteristic._indicate_status = status
characteristic._indicate_event.set()

if connection == characteristic._indicate_connection:
characteristic._indicate_status = status
characteristic._indicate_event.set()
else:
log_warn("Received indication for unexpected connection")

class BufferedCharacteristic(Characteristic):
def __init__(self, *args, max_len=20, append=False, **kwargs):
Expand Down
Loading