Skip to content

Commit 85f2865

Browse files
shrutiyerShruti IyerCopilot
authored andcommitted
Fix P0 local-auth and ACR DNS defaults (#554)
- Set disableLocalAuth=true in templates 16, 17, 18, and 19 AI account modules.\n- Add privatelink.azurecr.io defaults to 16/17/19 parameter files so default ACR paths are fully configured. Co-authored-by: Shruti Iyer <you@example.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 9d502dd commit 85f2865

7 files changed

Lines changed: 10 additions & 7 deletions

File tree

infrastructure/infrastructure-setup-bicep/16-private-network-standard-agent-apim-setup/main.bicepparam

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ param existingDnsZones = {
3333
'privatelink.search.windows.net': ''
3434
'privatelink.blob.core.windows.net': ''
3535
'privatelink.documents.azure.com': ''
36+
'privatelink.azurecr.io': ''
3637
'privatelink.azure-api.net': ''
3738
}
3839

@@ -44,6 +45,7 @@ param dnsZoneNames = [
4445
'privatelink.search.windows.net'
4546
'privatelink.blob.core.windows.net'
4647
'privatelink.documents.azure.com'
48+
'privatelink.azurecr.io'
4749
'privatelink.azure-api.net'
4850
]
4951

@@ -54,4 +56,3 @@ param dnsZoneNames = [
5456
param vnetAddressPrefix = ''
5557
param agentSubnetPrefix = ''
5658
param peSubnetPrefix = ''
57-

infrastructure/infrastructure-setup-bicep/16-private-network-standard-agent-apim-setup/modules-network-secured/ai-account-identity.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-04-01-preview' = {
3737
}
3838
] : null )
3939
// Set disable local auth to true or false. Agent service does not support API key based authentication
40-
disableLocalAuth: false
40+
disableLocalAuth: true
4141
}
4242
}
4343

infrastructure/infrastructure-setup-bicep/17-private-network-standard-user-assigned-identity-agent-setup/main.bicepparam

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ param existingDnsZones = {
3030
'privatelink.cognitiveservices.azure.com': ''
3131
'privatelink.search.windows.net': ''
3232
'privatelink.blob.core.windows.net': ''
33-
'privatelink.documents.azure.com': ''
33+
'privatelink.documents.azure.com': ''
34+
'privatelink.azurecr.io': ''
3435
}
3536

3637
//DNSZones names for validating if they exist
@@ -41,6 +42,7 @@ param dnsZoneNames = [
4142
'privatelink.search.windows.net'
4243
'privatelink.blob.core.windows.net'
4344
'privatelink.documents.azure.com'
45+
'privatelink.azurecr.io'
4446
]
4547

4648

@@ -67,4 +69,3 @@ param dnsZoneNames = [
6769
param vnetAddressPrefix = ''
6870
param agentSubnetPrefix = ''
6971
param peSubnetPrefix = ''
70-

infrastructure/infrastructure-setup-bicep/17-private-network-standard-user-assigned-identity-agent-setup/modules-network-secured/ai-account-identity.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-04-01-preview' = {
4141
}
4242
] : null )
4343
// Set disable local auth to true or false. Agent service does not support API key based authentication
44-
disableLocalAuth: false
44+
disableLocalAuth: true
4545
}
4646
}
4747

infrastructure/infrastructure-setup-bicep/18-managed-virtual-network/modules-network-secured/ai-account-identity.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-10-01-preview' = {
3535
useMicrosoftManagedNetwork: true
3636
}
3737
]
38-
disableLocalAuth: false
38+
disableLocalAuth: true
3939
}
4040
}
4141

infrastructure/infrastructure-setup-bicep/19-private-network-agent-tools/main.bicepparam

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,6 @@ param existingDnsZones = {
7777
'privatelink.search.windows.net': { subscriptionId: '', resourceGroup: '' }
7878
'privatelink.blob.core.windows.net': { subscriptionId: '', resourceGroup: '' }
7979
'privatelink.documents.azure.com': { subscriptionId: '', resourceGroup: '' }
80+
'privatelink.azurecr.io': { subscriptionId: '', resourceGroup: '' }
8081
'privatelink.fabric.microsoft.com': { subscriptionId: '', resourceGroup: '' }
8182
}

infrastructure/infrastructure-setup-bicep/19-private-network-agent-tools/modules-network-secured/ai-account-identity.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-04-01-preview' = {
4141
}
4242
]
4343
: null)
44-
disableLocalAuth: false
44+
disableLocalAuth: true
4545
}
4646
}
4747

0 commit comments

Comments
 (0)