Skip to content

Fix issue template language codes and CONTRIBUTING.md CLA URL inconsistency#680

Merged
leestott merged 5 commits into
mainfrom
copilot/fix-review-comments
Jul 2, 2026
Merged

Fix issue template language codes and CONTRIBUTING.md CLA URL inconsistency#680
leestott merged 5 commits into
mainfrom
copilot/fix-review-comments

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review feedback on PR #648 identified two issues: the translation feedback template used incorrect language codes that didn't match the repo's actual translations/ directory names, and the new root CONTRIBUTING.md used a different CLA URL than the existing etc/CONTRIBUTING.md.

Changes

  • .github/ISSUE_TEMPLATE/translation_feedback.yml — Replaced generic uppercase language codes (ES, ZH, JA, KO, AR) with the actual folder names from translations/ (e.g., es, zh-CN, zh-TW, zh-HK, pt-BR, pt-PT, etc.) so issue reports map directly to actionable directory paths.

  • CONTRIBUTING.md (root) — Aligned CLA URL to https://cla.microsoft.com (matching etc/CONTRIBUTING.md); added an explicit reference link to etc/CONTRIBUTING.md to reduce content drift between the two files.

  • .github/ISSUE_TEMPLATE/lesson_correction.yml — Added from PR Add repository standards: CONTRIBUTING guide, CODE_OF_CONDUCT, and structured issues #648 as-is; the file path placeholder was already correct (lessons/3-NeuralNetworks/03-Perceptron/README.md).

Copilot AI changed the title [WIP] Fix code based on review comments in PR #648 Fix issue template language codes and CONTRIBUTING.md CLA URL inconsistency Jul 2, 2026
Copilot AI requested a review from leestott July 2, 2026 12:52
@leestott leestott requested a review from Copilot July 2, 2026 12:57
@leestott leestott marked this pull request as ready for review July 2, 2026 12:58

@leestott leestott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at languages these are not correct

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates contributor-facing repository metadata by adding a root contributing guide and introducing structured GitHub Issue Forms, with a focus on making translation-related reports map cleanly to the repo’s translations/ directory and aligning CLA guidance.

Changes:

  • Added a root CONTRIBUTING.md, aligning the CLA URL to https://cla.microsoft.com and linking to etc/CONTRIBUTING.md.
  • Added a translation feedback issue form with locale-style language codes matching translations/ folder names.
  • Added a lesson correction/typo issue form for structured lesson fix reports.
Show a summary per file
File Description
CONTRIBUTING.md Adds a root contributing guide with CLA link alignment and a pointer to the more detailed etc/CONTRIBUTING.md.
.github/ISSUE_TEMPLATE/translation_feedback.yml Adds a translation feedback issue form with a language dropdown using repo folder locale tags.
.github/ISSUE_TEMPLATE/lesson_correction.yml Adds a lesson correction issue form for structured reports of typos, links, and code errors.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment thread .github/ISSUE_TEMPLATE/translation_feedback.yml Outdated
Comment thread CONTRIBUTING.md Outdated

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

looking at languages these are not correct

Fixed in the latest commit. The dropdown now lists all 54 languages that have folders under translations/ (e.g. bg, bn, cs, da, el, et, fa, fi, he, hr, hu, km, kn, lt, ml, mr, ms, my, ne, no, pa, pcm, ro, sk, sl, sr, sv, sw, ta, te, th, tl, ur, zh-MO, and the previously missing ones), ordered alphabetically by language name.

Copilot AI requested a review from leestott July 2, 2026 13:02
leestott and others added 2 commits July 2, 2026 16:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@leestott leestott merged commit 3662ce1 into main Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants