ci(scorecard): fix workflow artifact handling#695
Open
AAdewunmi wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Scorecard GitHub Actions workflow to make SARIF artifact upload/download more reliable and compatible with current GitHub Actions behavior.
Changes:
- Updated the checkout action reference used by the Scorecard analysis job.
- Switched SARIF artifact upload to a current artifact action and simplified the artifact name.
- Added a follow-up job to download and inspect the SARIF artifact produced by the analysis.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/scorecard.yml | Updates Scorecard workflow action references, standardizes the SARIF artifact name, and adds an artifact inspection job to validate the uploaded SARIF output. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Low
Comment on lines
61
to
66
| - name: "Upload artifact" | ||
| uses: actions/upload-artifact@97a0fba1372883ab732affbe8f94b823f91727db # v3.pre.node20 | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: SARIF file | ||
| # Use a simple, lowercase artifact name without spaces to avoid API validation | ||
| name: results-sarif | ||
| path: results.sarif |
Comment on lines
+81
to
+84
| - name: "Download SARIF artifact" | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: results-sarif |
Collaborator
|
@AAdewunmi please see feedback make changes and requests copilot review Thanks for splitting the PRs this make this much cleaner |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
Hi @leestott, Thanks for the review! I’ve updated the workflow in
The branch has been pushed, and it’s ready for Copilot review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Scorecard workflow so SARIF artifact handling works reliably and the workflow remains compatible with current GitHub Actions behavior.
Changes
Behaviour
Why
Validation
Result
The Scorecard workflow is now scoped to a focused fix for artifact handling and is ready for review as a separate PR.
Notes