Skip to content

Commit 0704650

Browse files
committed
cleanup: do some cleaning for the PR
cleanup cleanup cleanup cleanup
1 parent e6bbf9f commit 0704650

8 files changed

Lines changed: 4 additions & 17 deletions

File tree

aiopslab/orchestrator/orchestrator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
"""Orchestrator class that interfaces with the agent and the environment."""
55

6-
from aiopslab.service.helm import Helm
76
from aiopslab.service.kubectl import KubeCtl
87
from aiopslab.session import Session
98
from aiopslab.orchestrator.problems.registry import ProblemRegistry

aiopslab/service/apps/astronomy_shop.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from aiopslab.service.kubectl import KubeCtl
77
from aiopslab.service.apps.base import Application
88
from aiopslab.paths import ASTRONOMY_SHOP_METADATA
9-
from aiopslab.paths import config
109

1110

1211
class AstronomyShop(Application):
@@ -29,7 +28,6 @@ def deploy(self):
2928
"open-telemetry",
3029
"https://open-telemetry.github.io/opentelemetry-helm-charts",
3130
)
32-
3331
Helm.install(**self.helm_configs)
3432
Helm.assert_if_deployed(self.helm_configs["namespace"])
3533

aiopslab/service/apps/flight_ticket.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
from aiopslab.service.helm import Helm
55
from aiopslab.service.kubectl import KubeCtl
66
from aiopslab.service.apps.base import Application
7-
from aiopslab.paths import TARGET_MICROSERVICES
87
from aiopslab.paths import FLIGHT_TICKET_METADATA
9-
from aiopslab.paths import config
108

119

1210
class FlightTicket(Application):
@@ -29,7 +27,6 @@ def deploy(self):
2927
"flight-ticket",
3028
"https://xlab-uiuc.github.io/flight-ticket",
3129
)
32-
3330
Helm.install(**self.helm_configs)
3431
Helm.assert_if_deployed(self.helm_configs["namespace"])
3532

aiopslab/service/apps/socialnet.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from aiopslab.service.apps.base import Application
99
from aiopslab.paths import TARGET_MICROSERVICES
1010
from aiopslab.paths import SOCIAL_NETWORK_METADATA
11-
from aiopslab.paths import config
1211

1312

1413
class SocialNetwork(Application):
@@ -48,11 +47,11 @@ def deploy(self):
4847
node_architectures = self.kubectl.get_node_architectures()
4948
is_arm = any(arch in ["arm64", "aarch64"] for arch in node_architectures)
5049

51-
if "extra_args" not in self.helm_configs:
52-
self.helm_configs["extra_args"] = []
53-
5450
if is_arm:
5551
# Use the ARM-compatible image for media-frontend
52+
if "extra_args" not in self.helm_configs:
53+
self.helm_configs["extra_args"] = []
54+
5655
self.helm_configs["extra_args"].append(
5756
"--set media-frontend.container.image=jacksonarthurclark/media-frontend"
5857
)

aiopslab/service/apps/tidb_cluster_operator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from aiopslab.service.kubectl import KubeCtl
66
from aiopslab.service.apps.base import Application
77
from aiopslab.paths import TIDB_METADATA
8-
from aiopslab.paths import config
98

109

1110
class TiDBCluster(Application):

aiopslab/service/apps/train_ticket.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
from aiopslab.service.helm import Helm
55
from aiopslab.service.kubectl import KubeCtl
66
from aiopslab.service.apps.base import Application
7-
from aiopslab.paths import TARGET_MICROSERVICES
87
from aiopslab.paths import TRAIN_TICKET_METADATA
9-
from aiopslab.paths import config
108

119

1210
class TrainTicket(Application):
@@ -25,7 +23,6 @@ def load_app_json(self):
2523
def deploy(self):
2624
"""Deploy the Helm configurations."""
2725
self.kubectl.create_namespace_if_not_exist(self.namespace)
28-
2926
Helm.install(**self.helm_configs)
3027
Helm.assert_if_deployed(self.helm_configs["namespace"])
3128

aiopslab/service/helm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"""Interface for helm operations"""
55

66
import subprocess
7-
import time
87

98
from aiopslab.service.kubectl import KubeCtl
9+
from aiopslab.paths import config
1010

1111

1212
class Helm:

aiopslab/service/telemetry/prometheus.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
import os
55
import json
66
import yaml
7-
import time
87
from subprocess import CalledProcessError
98
from aiopslab.service.helm import Helm
109
from aiopslab.service.kubectl import KubeCtl
1110
from aiopslab.paths import PROMETHEUS_METADATA, BASE_DIR
12-
from aiopslab.paths import config
1311

1412

1513
class Prometheus:

0 commit comments

Comments
 (0)