Fix some gradle warnings

Author: trask

agent/agent-for-testing/build.gradle.kts

@@ -50,7 +50,7 @@ tasks {
     dependsOn(relocateJavaagentLibs)
     isolateClasses(relocateJavaagentLibs.get().outputs.files)
 
-    into("$buildDir/isolated/javaagentLibs")
+    into(layout.buildDirectory.dir("isolated/javaagentLibs"))
   }
 
   // 3. the relocated and isolated javaagent libs are merged together with the bootstrap libs (which undergo relocation

agent/agent/build.gradle.kts

@@ -95,7 +95,7 @@ tasks {
     dependsOn(relocateJavaagentLibs)
     isolateClasses(relocateJavaagentLibs.get().outputs.files)
 
-    into("$buildDir/isolated/javaagentLibs")
+    into(layout.buildDirectory.dir("isolated/javaagentLibs"))
   }
 
   // 3. the relocated and isolated javaagent libs are merged together with the bootstrap libs (which undergo relocation

buildSrc/src/main/kotlin/ai.javaagent-instrumentation.gradle.kts

@@ -62,9 +62,9 @@ tasks.withType<Test>().configureEach {
   // The sources are packaged into the testing jar so we need to make sure to exclude from the test
   // classpath, which automatically inherits them, to ensure our shaded versions are used.
   classpath = classpath.filter {
-    if (file("$buildDir/resources/main") == it || file("$buildDir/classes/java/main") == it) {
-      return@filter false
+    if (it == file(layout.buildDirectory.dir("resources/main")) || it == file(layout.buildDirectory.dir("classes/java/main"))) {
+      return false
     }
-    return@filter true
+    return true
   }
 }

buildSrc/src/main/kotlin/ai.smoke-test.gradle.kts

@@ -87,7 +87,7 @@ configurations.all {
 }
 
 tasks {
-  task<Test>("smokeTest") {
+  register<Test>("smokeTest") {
     useJUnitPlatform()
 
     // this is just to force building the agent first

etw/java/build.gradle

@@ -22,7 +22,9 @@ sourceSets {
   }
 }
 
-archivesBaseName = "applicationinsights-java-etw-provider"
+base {
+  archivesName = "applicationinsights-java-etw-provider"
+}
 
 logger.info "project ${project.path} prop: ai.etw.native.build=${System.properties['ai.etw.native.build']}"
 

gradle.properties

@@ -12,10 +12,5 @@ org.gradle.jvmargs=-XX:MaxMetaspaceSize=512m
 
 # org.gradle.warning.mode=fail
 
-# To allow caching more tasks in buildSrc project
-# This property is not mentioned in Gradle documentation
-# See https://github.com/gradle/gradle/issues/15214 for background info
-systemProp.org.gradle.kotlin.dsl.precompiled.accessors.strict=true
-
 # Workaround https://youtrack.jetbrains.com/issue/KT-34862
 kotlin.incremental=false