Skip to content

Commit d646eb1

Browse files
Copilotxiang17
andcommitted
Code review improvement: Extract SDK metrics to constant
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
1 parent 455b940 commit d646eb1

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

  • agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -758,21 +758,27 @@ private static List<ProcessorConfig> getLogProcessorConfigs(Configuration config
758758
|| processor.type == Configuration.ProcessorType.LOG)
759759
.collect(Collectors.toCollection(ArrayList::new));
760760
}
761+
762+
// SDK internal metrics that should not be exported to customers
763+
private static final String[] SDK_INTERNAL_METRICS_TO_DROP = {
764+
"otel.sdk.span.live",
765+
"otel.sdk.span.started",
766+
"otel.sdk.log.created"
767+
};
761768

762769
private static SdkMeterProviderBuilder configureMetrics(
763770
SdkMeterProviderBuilder builder, Configuration configuration) {
764771

765-
// drop internal OpenTelemetry SDK metrics
772+
// drop internal OpenTelemetry SDK metrics (legacy format)
766773
drop(builder, "io.opentelemetry.sdk.trace", "queueSize");
767774
drop(builder, "io.opentelemetry.sdk.trace", "processedSpans");
768775
drop(builder, "io.opentelemetry.sdk.logs", "queueSize");
769776
drop(builder, "io.opentelemetry.sdk.logs", "processedLogs");
770777

771-
// drop new SDK internal metrics added in OpenTelemetry 2.24.0
772-
// These metrics use different naming: otel.sdk.* instead of being under io.opentelemetry.sdk.* meter
773-
dropByName(builder, "otel.sdk.span.live");
774-
dropByName(builder, "otel.sdk.span.started");
775-
dropByName(builder, "otel.sdk.log.created");
778+
// drop SDK internal metrics added in OpenTelemetry 2.24.0
779+
for (String metricName : SDK_INTERNAL_METRICS_TO_DROP) {
780+
dropByName(builder, metricName);
781+
}
776782

777783
if (configuration.internal.preAggregatedStandardMetrics.enabled) {
778784
AiViewRegistry.registerViews(builder);

0 commit comments

Comments
 (0)