Conversation
trask
commented
Mar 17, 2025
Comment on lines
+27
to
+56
| testing.waitAndAssertTrace( | ||
| trace -> | ||
| trace | ||
| .hasRequestSatisying( | ||
| request -> | ||
| request | ||
| .hasName("GET /simple") | ||
| .hasSuccess(true) | ||
| .hasProperty("_MS.ProcessedByMetricExtractors", "True") | ||
| .hasTag("ai.operation.name", "GET /simple") | ||
| .hasNoParent()) | ||
| .hasDependencySatisying( | ||
| dependency -> | ||
| dependency | ||
| .hasName("example.Greeter/SayHello") | ||
| .hasTarget("localhost:10203") | ||
| .hasSuccess(true) | ||
| .hasProperty("_MS.ProcessedByMetricExtractors", "True") | ||
| .hasTag("ai.operation.name", "GET /simple") | ||
| .hasParent(trace.getRequestId(0))) | ||
| .hasRequestSatisying( | ||
| request -> | ||
| request | ||
| .hasName("example.Greeter/SayHello") | ||
| .hasSuccess(true) | ||
| .hasProperty("_MS.ProcessedByMetricExtractors", "True") | ||
| .hasTag("ai.operation.name", "example.Greeter/SayHello") | ||
| .hasParent(trace.getDependencyId(0))) | ||
| // auto-collected grpc events are suppressed by exporter because they are noisy | ||
| .hasMessageCount(0)); |
Member
Author
There was a problem hiding this comment.
this is what a test looks like with the new assertj wrappers
trask
requested review from
TimothyMothra,
harsimar,
heyams,
jeanbisutti,
rajkumar-rangaraj and
ramthi
as code owners
jeanbisutti
approved these changes
Mar 18, 2025
This was referenced Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier to read, also more aligned with upstream OpenTelemetry which uses similar assertj wrappers