Skip to content

Suppress warnings for some safe operations #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Jul 22, 2025
Merged

Suppress warnings for some safe operations #4371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/MemoryManagers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public static MemoryManagers of(MemoryManagement manager) {
"Unable to find garbage collector group for the memory manager");
}

@SafeVarargs
MemoryManagers(Class<? extends GarbageCollector>... allCollectors) {
this.managers = allCollectors;
}
Expand Down
4 changes: 3 additions & 1 deletion ...amework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,9 @@ public void afterAll(ExtensionContext context) throws Exception {

@SuppressWarnings("TypeParameterUnusedInFormals")
protected static <T extends Domain> T getBaseData(Envelope envelope) {
return ((Data<T>) envelope.getData()).getBaseData();
@SuppressWarnings("unchecked")
Data<T> data = (Data<T>) envelope.getData();
return data.getBaseData();
}

@SuppressWarnings("TypeParameterUnusedInFormals")
Expand Down
1 change: 1 addition & 0 deletions ...k/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ private static class BaseDataContractDeserializer implements JsonDeserializer<Ba

public BaseDataContractDeserializer() {
classMap = new HashMap<>();
@SuppressWarnings("unchecked")
Class<? extends Domain>[] classes =
new Class[] {
RequestData.class,
Expand Down
3 changes: 3 additions & 0 deletions ...crosoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ private <T extends Domain> List<T> getTelemetryDataByType(String type, boolean i
List<T> dataItems = new ArrayList<>();
for (Envelope e : items) {
if (!inRequestOnly || e.getTags().containsKey("ai.operation.id")) {
@SuppressWarnings("unchecked")
Data<T> dt = (Data<T>) e.getData();
dataItems.add(dt.getBaseData());
}
Expand All @@ -116,6 +117,7 @@ public <T extends Domain> List<T> getMessageDataInRequest(int numItems)
waitForItems("MessageData", e -> e.getTags().containsKey("ai.operation.id"), numItems);
List<T> dataItems = new ArrayList<>();
for (Envelope e : items) {
@SuppressWarnings("unchecked")
Data<T> dt = (Data<T>) e.getData();
dataItems.add(dt.getBaseData());
}
Expand All @@ -124,6 +126,7 @@ public <T extends Domain> List<T> getMessageDataInRequest(int numItems)

@SuppressWarnings("TypeParameterUnusedInFormals")
public <T extends Domain> T getBaseDataForType(int index, String type) {
@SuppressWarnings("unchecked")
Data<T> data = (Data<T>) getItemsEnvelopeDataType(type).get(index).getData();
return data.getBaseData();
}
Expand Down