Bug 620326: Reset IsChangingStatus on handled Reopen/Finish early-exit#9077
Draft
alexei-dobriansky wants to merge 1 commit into
Draft
Bug 620326: Reset IsChangingStatus on handled Reopen/Finish early-exit#9077alexei-dobriansky wants to merge 1 commit into
alexei-dobriansky wants to merge 1 commit into
Conversation
ReopenInspection and FinishInspectionAndPrompt set IsChangingStatus := true before firing OnBeforeReopenInspection / OnBeforeFinishInspection. When a subscriber set IsHandled := true the procedures exited before the IsChangingStatus := false cleanup, leaving the guard stuck true so a later OnModify skipped TestStatusOpen and a finished inspection could be modified. Reset the guard before the handled exit. Adds a manual subscriber test codeunit and two tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#620326
ReopenInspectionandFinishInspectionAndPromptsetIsChangingStatus := truebefore firing theOnBefore...integration event. When a subscriber setIsHandled := truethe procedures exited before theIsChangingStatus := falsecleanup, leaving the flag stucktrueso a laterOnModifyskippedTestStatusOpen()and a finished inspection could be modified. Reset the flag before the handled exit. Adds a manual subscriber test codeunit (139973) and two tests.