Merge-ES-Excluded-from-Calculation-to-W1#9089
Conversation
Copilot PR ReviewIteration 5 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
This comment was marked as resolved.
This comment was marked as resolved.
Agentic PR Review - Round 1Recommendation: Request ChangesWhat this PR doesThis PR promotes the ES SuggestionsS1 - Fix missing ES layer propagation S2 - Add W1 regression coverage for balances S3 - Filter My Vendor balance too Risk assessment and necessityRisk: This changes core customer and vendor balance calculations for every W1-derived country layer. The default value is false, so countries that never set the flag should keep current balances, but any code that sets the flag now changes customer cards, vendor cards, ledger remaining amounts, general ledger setup due balances, currency due balances, and statements. The area is financially sensitive, and the current failed propagation check shows the layer set is not yet internally consistent. Necessity: The change is necessary if ES Cartera behavior is being generalized: excluded redrawal/rejection detailed entries should not inflate normal balances. The scope is mostly right because ES-specific duplicate files are removed and W1 receives the common field and filters, but the PR must finish propagation, cover the new W1 behavior with tests, and fix the remaining vendor cue gap before merge.
|
|
@Alexander-Ya please review the suggestions |
What & why
Linked work
Fixes AB#636627
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility