[Master]-Project consumption: partial invoicing of non-inventory items posts negative adjustment value entry to wrong Item Ledger Entry

[neeleshsinghal]

AB#641520

[github-actions]

Copilot PR Review

Iteration 4 · Outcome: no-knowledge

No BCQuality knowledge file in any leaf domain (performance, security, privacy, upgrade, style, ui) applies to this diff; al-upgrade-review and al-ui-review returned not-applicable because the diff touches no upgrade codeunits/table schema and no page/control-add-in files. The agent self-review pass found no cross-cutting defect clearing the precision bar: the fix (replacing an exact-zero Invoiced Quantity filter with the Completely Invoiced boolean flag, so partially invoiced Item Ledger Entries are still matched when locating the linked Negative Adjmt. entry for non-inventory job consumption) is applied identically and completely across all 10 country layers that contain the affected procedure, and a corresponding regression test was added to both test codeunits (W1, RU) that exist for this scenario.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

No findings were posted for this iteration.

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[Copilot]

Pull request overview

Fixes a posting/application issue in purchase posting where partial invoicing of non-inventory items with project consumption could cause the “Negative Adjmt.” value entry to be applied/linked to the wrong Item Ledger Entry. The change adjusts how the posting logic selects the target “Negative Adjmt.” Item Ledger Entry during subsequent partial invoices and adds regression coverage.

Changes:

• Update Purch.-Post logic for non-inventory items to locate the relevant “Negative Adjmt.” Item Ledger Entry using Completely Invoiced = false (instead of Invoiced Quantity = 0) so partially invoiced entries are still selected.
• Add a regression test scenario (W1 + RU) covering two-step partial invoicing via Get Receipt Lines, validating invoiced quantities and ensuring no “Negative Adjmt.” value entry is linked to the “Purchase” ILE.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Layers/W1/Tests/Job/JobConsumptionPurchase.Codeunit.al	Adds regression scenario + helper routines for partial invoicing from receipt and verifying value entry linkage.
src/Layers/W1/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	Changes non-inventory applied ILE selection to use Completely Invoiced = false for “Negative Adjmt.” entries.
src/Layers/RU/Tests/Job/JobConsumptionPurchase.Codeunit.al	RU-layer equivalent regression scenario + helper routines.
src/Layers/RU/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	RU-layer equivalent Purch.-Post fix.
src/Layers/NA/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	NA-layer equivalent Purch.-Post fix.
src/Layers/IT/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	IT-layer equivalent Purch.-Post fix.
src/Layers/GB/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	GB-layer equivalent Purch.-Post fix.
src/Layers/FI/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	FI-layer equivalent Purch.-Post fix.
src/Layers/ES/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	ES-layer equivalent Purch.-Post fix.
src/Layers/CH/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	CH-layer equivalent Purch.-Post fix.
src/Layers/BE/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	BE-layer equivalent Purch.-Post fix.
src/Layers/APAC/BaseApp/Purchases/Posting/PurchPost.Codeunit.al	APAC-layer equivalent Purch.-Post fix.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.