Skip to content

[Master]-Project consumption: partial invoicing of non-inventory items posts negative adjustment value entry to wrong Item Ledger Entry #9133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neeleshsinghal wants to merge 3 commits into
base: main
Choose a base branch
from
+204 −10
Open

[Master]-Project consumption: partial invoicing of non-inventory items posts negative adjustment value entry to wrong Item Ledger Entry #9133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
771ab63
640811 initial commit
neeleshsinghal Jul 6, 2026
67817ea
Potential fix for pull request finding
neeleshsinghal Jul 7, 2026
69ea8cd
Add test for partial invoicing with negative adjustment
neeleshsinghal Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Layers/APAC/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6316,7 +6316,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/BE/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6125,7 +6125,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/CH/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6086,7 +6086,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/ES/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6204,7 +6204,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/FI/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6083,7 +6083,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/GB/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6110,7 +6110,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/IT/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6273,7 +6273,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/NA/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6285,7 +6285,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/RU/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6262,7 +6262,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
97 changes: 97 additions & 0 deletions src/Layers/RU/Tests/Job/JobConsumptionPurchase.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2778,6 +2778,67 @@ codeunit 136302 "Job Consumption Purchase"
VerifyItemLedgEntriesInvoiced(Item."No.", PurchaseLine.Amount);
end;

[Test]
procedure PartialInvoicingNonInvItemWithJobAppliesNegAdjmtToCorrectILE()
var
Item: Record Item;
Vendor: Record Vendor;
JobTask: Record "Job Task";
PurchaseHeader: Record "Purchase Header";
PurchaseLine: Record "Purchase Line";
PurchaseILE: Record "Item Ledger Entry";
NegAdjmtILE: Record "Item Ledger Entry";
ReceiptNo: Code[20];
UnitCost: Decimal;
FirstQtyToInvoice: Decimal;
SecondQtyToInvoice: Decimal;
begin
// [FEATURE] [Partial Posting] [Get Receipt Lines] [Non-Inventory]
// [SCENARIO 640811] Partial invoicing of a non-inventory item with a project applies the project consumption
// [SCENARIO 640811] "Negative Adjmt." value entry to the correct Item Ledger Entry.
Initialize();
UnitCost := LibraryRandom.RandDecInRange(100, 200, 2);
FirstQtyToInvoice := 0.2;
SecondQtyToInvoice := 0.3;

// [GIVEN] A non-inventory item and a project with a project task.
LibraryInventory.CreateNonInventoryTypeItem(Item);
CreateJobWithJobTask(JobTask);

// [GIVEN] A purchase order for the non-inventory item, Quantity = 1, with Project No. and Project Task No.
LibraryPurchase.CreateVendor(Vendor);
CreatePurchaseHeader(PurchaseHeader."Document Type"::Order, Vendor."No.", PurchaseHeader);
LibraryPurchase.CreatePurchaseLine(PurchaseLine, PurchaseHeader, PurchaseLine.Type::Item, Item."No.", 1);
PurchaseLine.Validate("Direct Unit Cost", UnitCost);
PurchaseLine.Validate("Job No.", JobTask."Job No.");
PurchaseLine.Validate("Job Task No.", JobTask."Job Task No.");
PurchaseLine.Modify(true);

// [GIVEN] The purchase receipt is posted for the full quantity.
// [GIVEN] Two Item Ledger Entries are created: a "Purchase" entry and a "Negative Adjmt." entry for the project.
ReceiptNo := LibraryPurchase.PostPurchaseDocument(PurchaseHeader, true, false);

// [GIVEN] A first partial invoice for Quantity = 0.2 is created through "Get Receipt Lines" and posted.
CreateAndPostPurchInvoiceFromReceipt(Vendor."No.", ReceiptNo, FirstQtyToInvoice);

// [WHEN] A second partial invoice for Quantity = 0.3 is created through "Get Receipt Lines" and posted.
CreateAndPostPurchInvoiceFromReceipt(Vendor."No.", ReceiptNo, SecondQtyToInvoice);

// [THEN] The "Purchase" Item Ledger Entry has Invoiced Quantity = 0.5, matching the invoiced receipt quantity.
FindItemLedgEntry(
PurchaseILE, Item."No.", PurchaseILE."Entry Type"::Purchase, PurchaseILE."Document Type"::"Purchase Receipt", ReceiptNo);
PurchaseILE.TestField("Invoiced Quantity", FirstQtyToInvoice + SecondQtyToInvoice);

// [THEN] No "Negative Adjmt." value entry is linked to the "Purchase" Item Ledger Entry.
VerifyNoNegativeAdjmtValueEntryOnILE(PurchaseILE."Entry No.");

// [THEN] The "Negative Adjmt." Item Ledger Entry has Invoiced Quantity = -0.5.
FindItemLedgEntry(
NegAdjmtILE, Item."No.", NegAdjmtILE."Entry Type"::"Negative Adjmt.",
NegAdjmtILE."Document Type"::"Purchase Receipt", ReceiptNo);
NegAdjmtILE.TestField("Invoiced Quantity", -(FirstQtyToInvoice + SecondQtyToInvoice));
end;

[Test]
procedure UndoPurchaseReceiptWithNegativeQuantityAndJob()
var
Expand Down Expand Up @@ -5500,6 +5561,42 @@ codeunit 136302 "Job Consumption Purchase"
PurchaseLine.ShowItemChargeAssgnt();
end;

local procedure CreateAndPostPurchInvoiceFromReceipt(VendorNo: Code[20]; ReceiptDocumentNo: Code[20]; QtyToInvoice: Decimal)
var
PurchaseHeader: Record "Purchase Header";
PurchaseLine: Record "Purchase Line";
PurchRcptLine: Record "Purch. Rcpt. Line";
PurchGetReceipt: Codeunit "Purch.-Get Receipt";
begin
// Create a purchase invoice, pull in the posted receipt lines using "Get Receipt Lines" and
// reduce the line quantity so that only part of the receipt is invoiced, then post the invoice.
LibraryPurchase.CreatePurchHeader(PurchaseHeader, PurchaseHeader."Document Type"::Invoice, VendorNo);
PurchaseHeader.Validate("Vendor Invoice No.", LibraryUtility.GenerateGUID());
PurchaseHeader.Modify(true);

PurchRcptLine.SetRange("Document No.", ReceiptDocumentNo);
PurchGetReceipt.SetPurchHeader(PurchaseHeader);
PurchGetReceipt.CreateInvLines(PurchRcptLine);

PurchaseLine.SetRange("Document Type", PurchaseHeader."Document Type");
PurchaseLine.SetRange("Document No.", PurchaseHeader."No.");
PurchaseLine.SetRange(Type, PurchaseLine.Type::Item);
PurchaseLine.FindFirst();
PurchaseLine.Validate(Quantity, QtyToInvoice);
PurchaseLine.Modify(true);

LibraryPurchase.PostPurchaseDocument(PurchaseHeader, false, true);
end;

local procedure VerifyNoNegativeAdjmtValueEntryOnILE(ItemLedgerEntryNo: Integer)
var
ValueEntry: Record "Value Entry";
begin
ValueEntry.SetRange("Item Ledger Entry No.", ItemLedgerEntryNo);
ValueEntry.SetRange("Item Ledger Entry Type", ValueEntry."Item Ledger Entry Type"::"Negative Adjmt.");
Assert.RecordIsEmpty(ValueEntry);
end;

local procedure AttachJobToPurchaseDocument(JobTask: Record "Job Task"; PurchaseHeader: Record "Purchase Header"; JobPlanningLineNo: Integer)
var
PurchaseLine: Record "Purchase Line";
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/W1/BaseApp/Purchases/Posting/PurchPost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6077,7 +6077,7 @@ codeunit 90 "Purch.-Post"
ItemLedgerEntry.SetRange("Document Line No.", ItemLedgerEntry."Document Line No.");
ItemLedgerEntry.SetRange("Entry Type", ItemLedgerEntry."Entry Type"::"Negative Adjmt.");
ItemLedgerEntry.SetRange("Item No.", ItemLedgerEntry."Item No.");
ItemLedgerEntry.SetRange("Invoiced Quantity", 0);
ItemLedgerEntry.SetRange("Completely Invoiced", false);
if ItemLedgerEntry.FindFirst() then
ItemJournalLine."Item Shpt. Entry No." := ItemLedgerEntry."Entry No."
end;
Expand Down
97 changes: 97 additions & 0 deletions src/Layers/W1/Tests/Job/JobConsumptionPurchase.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2805,6 +2805,67 @@ codeunit 136302 "Job Consumption Purchase"
VerifyItemLedgEntriesInvoiced(Item."No.", PurchaseLine.Amount);
end;

[Test]
procedure PartialInvoicingNonInvItemWithJobAppliesNegAdjmtToCorrectILE()
var
Comment thread
neeleshsinghal marked this conversation as resolved.
Item: Record Item;
Vendor: Record Vendor;
JobTask: Record "Job Task";
PurchaseHeader: Record "Purchase Header";
PurchaseLine: Record "Purchase Line";
PurchaseILE: Record "Item Ledger Entry";
NegAdjmtILE: Record "Item Ledger Entry";
ReceiptNo: Code[20];
UnitCost: Decimal;
FirstQtyToInvoice: Decimal;
SecondQtyToInvoice: Decimal;
begin
// [FEATURE] [Partial Posting] [Get Receipt Lines] [Non-Inventory]
// [SCENARIO 640811] Partial invoicing of a non-inventory item with a project applies the project consumption
// [SCENARIO 640811] "Negative Adjmt." value entry to the correct Item Ledger Entry.
Initialize();
UnitCost := LibraryRandom.RandDecInRange(100, 200, 2);
FirstQtyToInvoice := 0.2;
SecondQtyToInvoice := 0.3;

// [GIVEN] A non-inventory item and a project with a project task.
LibraryInventory.CreateNonInventoryTypeItem(Item);
CreateJobWithJobTask(JobTask);

// [GIVEN] A purchase order for the non-inventory item, Quantity = 1, with Project No. and Project Task No.
LibraryPurchase.CreateVendor(Vendor);
CreatePurchaseHeader(PurchaseHeader."Document Type"::Order, Vendor."No.", PurchaseHeader);
LibraryPurchase.CreatePurchaseLine(PurchaseLine, PurchaseHeader, PurchaseLine.Type::Item, Item."No.", 1);
PurchaseLine.Validate("Direct Unit Cost", UnitCost);
PurchaseLine.Validate("Job No.", JobTask."Job No.");
PurchaseLine.Validate("Job Task No.", JobTask."Job Task No.");
PurchaseLine.Modify(true);

// [GIVEN] The purchase receipt is posted for the full quantity.
// [GIVEN] Two Item Ledger Entries are created: a "Purchase" entry and a "Negative Adjmt." entry for the project.
ReceiptNo := LibraryPurchase.PostPurchaseDocument(PurchaseHeader, true, false);

// [GIVEN] A first partial invoice for Quantity = 0.2 is created through "Get Receipt Lines" and posted.
CreateAndPostPurchInvoiceFromReceipt(Vendor."No.", ReceiptNo, FirstQtyToInvoice);

// [WHEN] A second partial invoice for Quantity = 0.3 is created through "Get Receipt Lines" and posted.
CreateAndPostPurchInvoiceFromReceipt(Vendor."No.", ReceiptNo, SecondQtyToInvoice);

// [THEN] The "Purchase" Item Ledger Entry has Invoiced Quantity = 0.5, matching the invoiced receipt quantity.
FindItemLedgEntry(
PurchaseILE, Item."No.", PurchaseILE."Entry Type"::Purchase, PurchaseILE."Document Type"::"Purchase Receipt", ReceiptNo);
PurchaseILE.TestField("Invoiced Quantity", FirstQtyToInvoice + SecondQtyToInvoice);

// [THEN] No "Negative Adjmt." value entry is linked to the "Purchase" Item Ledger Entry.
VerifyNoNegativeAdjmtValueEntryOnILE(PurchaseILE."Entry No.");

// [THEN] The "Negative Adjmt." Item Ledger Entry has Invoiced Quantity = -0.5.
FindItemLedgEntry(
NegAdjmtILE, Item."No.", NegAdjmtILE."Entry Type"::"Negative Adjmt.",
NegAdjmtILE."Document Type"::"Purchase Receipt", ReceiptNo);
NegAdjmtILE.TestField("Invoiced Quantity", -(FirstQtyToInvoice + SecondQtyToInvoice));
end;

[Test]
procedure UndoPurchaseReceiptWithNegativeQuantityAndJob()
var
Expand Down Expand Up @@ -5536,6 +5597,42 @@ codeunit 136302 "Job Consumption Purchase"
PurchaseLine.ShowItemChargeAssgnt();
end;

local procedure CreateAndPostPurchInvoiceFromReceipt(VendorNo: Code[20]; ReceiptDocumentNo: Code[20]; QtyToInvoice: Decimal)
var
PurchaseHeader: Record "Purchase Header";
PurchaseLine: Record "Purchase Line";
PurchRcptLine: Record "Purch. Rcpt. Line";
PurchGetReceipt: Codeunit "Purch.-Get Receipt";
begin
// Create a purchase invoice, pull in the posted receipt lines using "Get Receipt Lines" and
// reduce the line quantity so that only part of the receipt is invoiced, then post the invoice.
LibraryPurchase.CreatePurchHeader(PurchaseHeader, PurchaseHeader."Document Type"::Invoice, VendorNo);
PurchaseHeader.Validate("Vendor Invoice No.", LibraryUtility.GenerateGUID());
PurchaseHeader.Modify(true);

PurchRcptLine.SetRange("Document No.", ReceiptDocumentNo);
PurchGetReceipt.SetPurchHeader(PurchaseHeader);
PurchGetReceipt.CreateInvLines(PurchRcptLine);

PurchaseLine.SetRange("Document Type", PurchaseHeader."Document Type");
PurchaseLine.SetRange("Document No.", PurchaseHeader."No.");
PurchaseLine.SetRange(Type, PurchaseLine.Type::Item);
PurchaseLine.FindFirst();
PurchaseLine.Validate(Quantity, QtyToInvoice);
PurchaseLine.Modify(true);

LibraryPurchase.PostPurchaseDocument(PurchaseHeader, false, true);
end;

local procedure VerifyNoNegativeAdjmtValueEntryOnILE(ItemLedgerEntryNo: Integer)
var
ValueEntry: Record "Value Entry";
begin
ValueEntry.SetRange("Item Ledger Entry No.", ItemLedgerEntryNo);
ValueEntry.SetRange("Item Ledger Entry Type", ValueEntry."Item Ledger Entry Type"::"Negative Adjmt.");
Assert.RecordIsEmpty(ValueEntry);
end;

local procedure AttachJobToPurchaseDocument(JobTask: Record "Job Task"; PurchaseHeader: Record "Purchase Header"; JobPlanningLineNo: Integer)
var
PurchaseLine: Record "Purchase Line";
Expand Down
Loading