Fix TS issues in JS samples (#4040)

* Add ts-check flag and fix issues (samples 2-7)

* Add ts-check flag and fix issues (samples 8-17)

* Add ts-check flag and fix issues (samples 18-24)

* Add ts-check flag and fix issues (samples 40-47)

* Add ts-check flag and fix issues (samples 48-49)

* Add ts-check flag and fix issues (samples 84-86)

* Add ts-check flag and fix issues (samples 80-83)

* Add missing quote in comment.

* Apply feedback

Author: ceciliaavila

samples/javascript_nodejs/02.echo-bot/bot.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const { ActivityHandler, MessageFactory } = require('botbuilder');
 
 class EchoBot extends ActivityHandler {
@@ -15,7 +17,7 @@ class EchoBot extends ActivityHandler {
         });
 
         this.onMembersAdded(async (context, next) => {
-            const membersAdded = context.activity.membersAdded;
+            const membersAdded = context.activity.membersAdded ?? [];
             const welcomeText = 'Hello and welcome!';
             for (let cnt = 0; cnt < membersAdded.length; ++cnt) {
                 if (membersAdded[cnt].id !== context.activity.recipient.id) {

samples/javascript_nodejs/02.echo-bot/index.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const path = require('path');
 
 const dotenv = require('dotenv');

samples/javascript_nodejs/03.welcome-users/bots/welcomeBot.js

@@ -1,16 +1,20 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 // Import required Bot Framework classes.
 const { ActionTypes, ActivityHandler, CardFactory } = require('botbuilder');
 
+/** @import { UserState } from 'botbuilder' */
+
 // Welcomed User property name
 const WELCOMED_USER = 'welcomedUserProperty';
 
 class WelcomeBot extends ActivityHandler {
     /**
      *
-     * @param {UserState} User state to persist boolean flag to indicate
+     * @param {UserState} userState to persist boolean flag to indicate
      *                    if the bot had already welcomed the user
      */
     constructor(userState) {

samples/javascript_nodejs/03.welcome-users/index.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 // Import required packages
 const path = require('path');
 

samples/javascript_nodejs/05.multi-turn-prompt/bots/dialogBot.js

@@ -1,14 +1,19 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const { ActivityHandler } = require('botbuilder');
 
+/** @import { ConversationState, UserState } from 'botbuilder' */
+/** @import { UserProfileDialog } from '../dialogs/userProfileDialog' */
+
 class DialogBot extends ActivityHandler {
     /**
      *
      * @param {ConversationState} conversationState
      * @param {UserState} userState
-     * @param {Dialog} dialog
+     * @param {UserProfileDialog} dialog
      */
     constructor(conversationState, userState, dialog) {
         super();

samples/javascript_nodejs/05.multi-turn-prompt/dialogs/userProfileDialog.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const { MessageFactory } = require('botbuilder');
 const {
     AttachmentPrompt,
@@ -112,7 +114,7 @@ class UserProfileDialog extends ComponentDialog {
         // We can send messages to the user at any point in the WaterfallStep.
         await step.context.sendActivity(msg);
 
-        if (step.context.activity.channelId === Channels.msteams) {
+        if (step.context.activity.channelId === Channels.Msteams) {
             // This attachment prompt example is not designed to work for Teams attachments, so skip it in this case
             await step.context.sendActivity('Skipping attachment prompt in Teams channel...');
             return await step.next(undefined);

samples/javascript_nodejs/05.multi-turn-prompt/index.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const restify = require('restify');
 const path = require('path');
 

samples/javascript_nodejs/05.multi-turn-prompt/userProfile.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 class UserProfile {
     constructor(transport, name, age, picture) {
         this.transport = transport;

samples/javascript_nodejs/06.using-cards/bots/dialogBot.js

@@ -1,8 +1,13 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const { ActivityHandler } = require('botbuilder');
 
+/** @import { ConversationState, UserState } from 'botbuilder' */
+/** @import { MainDialog } from '../dialogs/mainDialog' */
+
 /**
  * This IBot implementation can run any type of Dialog. The use of type parameterization is to allows multiple different bots
  * to be run at different endpoints within the same project. This can be achieved by defining distinct Controller types
@@ -15,7 +20,7 @@ class DialogBot extends ActivityHandler {
      *
      * @param {ConversationState} conversationState
      * @param {UserState} userState
-     * @param {Dialog} dialog
+     * @param {MainDialog} dialog
      */
     constructor(conversationState, userState, dialog) {
         super();

samples/javascript_nodejs/06.using-cards/bots/richCardsBot.js

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// @ts-check
+
 const { MessageFactory } = require('botbuilder');
 const { DialogBot } = require('./dialogBot');
 
@@ -13,7 +15,7 @@ class RichCardsBot extends DialogBot {
         super(conversationState, userState, dialog);
 
         this.onMembersAdded(async (context, next) => {
-            const membersAdded = context.activity.membersAdded;
+            const membersAdded = context.activity.membersAdded ?? [];
             for (let cnt = 0; cnt < membersAdded.length; cnt++) {
                 if (membersAdded[cnt].id !== context.activity.recipient.id) {
                     const reply = MessageFactory.text('Welcome to CardBot. ' +