Feedback form aria-label computed value does not match on screen text #2277
lexi-taylorpull-request-validation.yml
on: pull_request
Build
3m 21s
Unit test
6m 4s
Build samples
26s
Static code analysis
4m 49s
Type definitions test
4m 23s
Matrix: html-test
Merge test results
2m 33s
Merge test snapshots
3s
Annotations
12 errors
|
Static code analysis:
packages/component/src/Attachment/Text/private/Markdownable.tsx#L29
Replace `{text}` with `⏎······{text}⏎····`
|
|
Static code analysis:
packages/component/src/Attachment/Text/private/Markdownable.tsx#L29
Props should be sorted alphabetically
|
|
Static code analysis:
packages/component/src/Attachment/Text/private/Markdownable.tsx#L29
Prop "id" is forbidden on DOM Nodes
|
|
Static code analysis:
packages/component/src/Attachment/Text/private/Markdownable.tsx#L27
Props should be sorted alphabetically
|
|
Static code analysis:
packages/component/src/Attachment/Text/private/Markdownable.tsx#L27
Props should be sorted alphabetically
|
|
Static code analysis:
packages/component/src/Attachment/Text/private/Markdownable.tsx#L27
Prop "id" is forbidden on DOM Nodes
|
|
Static code analysis:
packages/component/src/ActivityFeedback/private/FeedbackForm.tsx#L65
Props should be sorted alphabetically
|
|
Static code analysis:
packages/component/src/ActivityFeedback/private/FeedbackForm.tsx#L65
Replace `<Markdownable·id={disclaimerId}·className={classNames['feedback-form__form-footer']}·text={disclaimer}·/>` with `(⏎········<Markdownable·id={disclaimerId}·className={classNames['feedback-form__form-footer']}·text={disclaimer}·/>⏎······)`
|
|
Static code analysis:
packages/component/src/ActivityFeedback/private/FeedbackForm.tsx#L50
Replace `{localize('FEEDBACK_FORM_TITLE')}` with `⏎········{localize('FEEDBACK_FORM_TITLE')}⏎······`
|
|
Static code analysis:
packages/component/src/ActivityFeedback/private/FeedbackForm.tsx#L50
Prop "id" is forbidden on DOM Nodes
|
|
HTML test (7/17)
Process completed with exit code 1.
|
|
› avatar/layout.fullCustomized.rtl.html:
packages/test/harness/src/host/common/host/snapshot.js#L15
Expected image to match or be a close match to snapshot but was 0.03616898148148148% different from snapshot (100 differing pixels).
See diff for details: /home/runner/work/BotFramework-WebChat/BotFramework-WebChat/__tests__/html2/avatar/layout.fullCustomized.rtl.html.snap-1-diff.png
at toMatchImageSnapshot (packages/test/harness/src/host/common/host/snapshot.js:15:24)
at node_modules/@babel/runtime/helpers/regeneratorRuntime.js:52:18
at Generator.<anonymous> (node_modules/@babel/runtime/helpers/regenerator.js:52:51)
at Generator.next (node_modules/@babel/runtime/helpers/regeneratorDefine.js:11:21)
at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
docker
Expired
|
93.3 MB |
sha256:b81fa854cd093d534dc5d5b7a8a827c7ad46bb57a91e2efcdad21f5835ad2d5b
|
|
|
test-result
Expired
|
1.64 MB |
sha256:6eb01b789a43ec80ddffd0514a501425edaed5f7c0fd0c0650ec70625dcdd9bd
|
|
|
test-snapshot-diff
Expired
|
116 KB |
sha256:ba85b4c052658de5b169c9287a9c2e3c1df59165779bd1362336f7b9ae6734ba
|
|