fix: Only use role="form" when card has original aria-label from speak

Cards without "speak" that have form inputs were getting role="form"
from the derived aria-label, causing landmark-unique axe violations
when the page also contains the send box <form>. Now only cards with
an explicit "speak" property get role="form".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: uzirthapa

__tests__/html2/accessibility/adaptiveCard/hack.roleMod.ariaLabelFromTextContent.html

@@ -86,9 +86,9 @@
         expect(cardWithSpeak.getAttribute('role')).toBe('figure');
 
         // Card with form inputs and no speak: aria-label should be derived from text content,
-        // and role should be "form" because it has inputs and an aria-label.
+        // but role should be "figure" (not "form") to avoid duplicate form landmarks on the page.
         expect(cardFormNoSpeak.getAttribute('aria-label')).toBeTruthy();
-        expect(cardFormNoSpeak.getAttribute('role')).toBe('form');
+        expect(cardFormNoSpeak.getAttribute('role')).toBe('figure');
       });
     </script>
   </body>

packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardHacks/useRoleModEffect.ts

@@ -37,11 +37,14 @@ export default function useRoleModEffect(
 ): readonly [(cardElement: HTMLElement) => void, () => void] {
   const modder = useMemo(
     () => (_, cardElement: HTMLElement) => {
+      // Check if the card already has an aria-label from the "speak" property before we derive one.
+      const hasOriginalAriaLabel = !!cardElement.getAttribute('aria-label');
+
       // If the card doesn't have an aria-label (i.e. no "speak" property was set),
       // derive one from the card's visible text content so screen readers can announce it.
       let undoAriaLabel: (() => void) | undefined;
 
-      if (!cardElement.getAttribute('aria-label')) {
+      if (!hasOriginalAriaLabel) {
         const textContent = (cardElement.textContent || '').replace(/\s+/gu, ' ').trim();
 
         if (textContent) {
@@ -54,11 +57,16 @@ export default function useRoleModEffect(
         }
       }
 
+      // Only use role="form" when the card has an original aria-label (from "speak" property).
+      // Derived aria-labels should use role="figure" to avoid duplicate form landmarks
+      // when the page also contains the send box <form>.
       const undoRole = setOrRemoveAttributeIfFalseWithUndo(
         cardElement,
         'role',
         // "form" role requires either "aria-label", "aria-labelledby", or "title".
-        (cardElement.querySelector('button, input, select, textarea') && cardElement.getAttribute('aria-label')) ||
+        (cardElement.querySelector('button, input, select, textarea') &&
+          hasOriginalAriaLabel &&
+          cardElement.getAttribute('aria-label')) ||
           cardElement.getAttribute('aria-labelledby') ||
           cardElement.getAttribute('title')
           ? 'form'