Better naming

Author: OEvgeny

CHANGELOG.md

@@ -103,8 +103,9 @@ Breaking changes in this release:
    - Attaching files will no longer remove previously attached files
    - Updated Fluent theme to use the new attachment preview feature
 - Added collapsible activity and activity with abstract handling, in PR [#5506](https://github.com/microsoft/BotFramework-WebChat/pull/5506), in PR [#5513](https://github.com/microsoft/BotFramework-WebChat/pull/5513), in PR [#5771](https://github.com/microsoft/BotFramework-WebChat/pull/5771), by [@OEvgeny](https://github.com/OEvgeny)
-   - Added `styleOptions.collapsibleGroupingDefaultOpen` to configure whether collapsible part groups are open by default, defaults to `true`
-   - In the Fluent theme "copilot" variant, collapsible groups now default to closed
+   - Added `styleOptions.partGroupDefaultOpen` to configure whether part groups are open by default, defaults to `true`
+   - Added `styleOptions.referencesDefaultOpen` to configure whether references are open by default, defaults to `true`
+   - In the Fluent theme "copilot" variant, part groups and references now default to closed
 - Added `disableFileUpload` flag to completelly disable file upload feature, in PR [#5508](https://github.com/microsoft/BotFramework-WebChat/pull/5508), by [@JamesNewbyAtMicrosoft](https://github.com/JamesNewbyAtMicrosoft)
    - Deprecated `hideUploadButton` in favor of `disableFileUpload`.
    - Updated `BasicSendBoxToolbar` to rely solely on `disableFileUpload`.

packages/api/src/StyleOptions.ts

@@ -967,18 +967,18 @@ type StyleOptions = {
   speechRecognitionContinuous?: boolean | undefined;
 
   /**
-   * Whether collapsible activity groupings ("part" groups) are open by default.
+   * Whether part groups are open by default.
    *
    * @default true
    */
-  collapsibleGroupingDefaultOpen?: boolean | undefined;
+  partGroupDefaultOpen?: boolean | undefined;
 
   /**
-   * Whether link definitions (citation references) are open by default.
+   * Whether references (citation link definitions) are open by default.
    *
    * @default true
    */
-  linkDefinitionsDefaultOpen?: boolean | undefined;
+  referencesDefaultOpen?: boolean | undefined;
 
   /**
    * Defines how activities are being grouped by (in the order of appearance in the array). Default to `['sender', 'status', 'part']` or `sender,status` in CSS.

packages/api/src/defaultStyleOptions.ts

@@ -313,8 +313,9 @@ const DEFAULT_OPTIONS: Required<StyleOptions> = {
   // Speech recognition
   speechRecognitionContinuous: false,
 
-  collapsibleGroupingDefaultOpen: true,
-  linkDefinitionsDefaultOpen: true,
+  partGroupDefaultOpen: true,
+  referencesDefaultOpen: true,
+
   groupActivitiesBy: ['sender', 'status', 'part'],
 
   // Send box attachment bar

packages/component/src/LinkDefinition/LinkDefinitions.tsx

@@ -55,14 +55,11 @@ const LinkDefinitions = <TAccessoryProps extends {}>({
   const localizeWithPlural = useLocalizer({ plural: true });
   const summaryRef = useRef<HTMLElement>(null);
   const classNames = useStyles(styles);
-  const [{ linkDefinitionsDefaultOpen }] = useStyleOptions();
+  const [{ referencesDefaultOpen }] = useStyleOptions();
 
   const headerText = localizeWithPlural(REFERENCE_LIST_HEADER_IDS, childrenCount(children));
 
-  const defaultOpenString = useMemo(
-    () => (linkDefinitionsDefaultOpen ? 'true' : 'false'),
-    [linkDefinitionsDefaultOpen]
-  );
+  const defaultOpenString = useMemo(() => (referencesDefaultOpen ? 'true' : 'false'), [referencesDefaultOpen]);
 
   const handleToggle = useCallback<ReactEventHandler<HTMLDetailsElement>>(event => {
     const summary = summaryRef.current;
@@ -80,7 +77,7 @@ const LinkDefinitions = <TAccessoryProps extends {}>({
       // eslint-disable-next-line react/forbid-dom-props
       id={id}
       onToggle={handleToggle}
-      open={linkDefinitionsDefaultOpen}
+      open={referencesDefaultOpen}
     >
       <summary
         aria-controls={id}

packages/component/src/Middleware/ActivityGrouping/ui/PartGrouping/private/PartGroupingActivity.tsx

@@ -143,8 +143,8 @@ function PartGroupingActivity(props: PartGroupingActivityProps) {
 
   const classNames = useStyles(styles);
   const getKeyByActivity = useGetKeyByActivity();
-  const [{ collapsibleGroupingDefaultOpen }] = useStyleOptions();
-  const [isGroupOpen, setIsGroupOpen] = useState(collapsibleGroupingDefaultOpen);
+  const [{ partGroupDefaultOpen }] = useStyleOptions();
+  const [isGroupOpen, setIsGroupOpen] = useState(partGroupDefaultOpen);
 
   const messages = useMemo(
     () => activities.map(activity => getOrgSchemaMessage(activity.entities)).filter(message => !!message),

packages/fluent-theme/src/private/FluentThemeProvider.tsx

@@ -104,7 +104,7 @@ function FluentThemeProvider(props: FluentThemeProviderProps) {
   const fluentStyleOptions = useMemo(
     () =>
       Object.freeze({
-        ...(variant === 'copilot' && { collapsibleGroupingDefaultOpen: false, linkDefinitionsDefaultOpen: false }),
+        ...(variant === 'copilot' && { partGroupDefaultOpen: false, referencesDefaultOpen: false }),
         feedbackActionsPlacement: 'activity-actions',
         stylesRoot
       }),