Skip to content

Commit 11b415e

Browse files
committed
suggestions
1 parent 90b5129 commit 11b415e

5 files changed

Lines changed: 38 additions & 29 deletions

File tree

packages/component/src/Activity/private/FeedbackForm.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { useRefFrom } from 'use-ref-from';
55

66
import useStyleSet from '../../hooks/useStyleSet';
77
import testIds from '../../testIds';
8-
import FeedbackFormDisclaimer from './FeedbackFormDisclaimer';
8+
import Markdownable from '../../Attachment/Text/private/Markdownable';
99
import TextArea from './FeedbackTextArea';
1010

1111
const { useLocalizer, usePostActivity } = hooks;
@@ -70,7 +70,7 @@ function FeedbackForm({ feedbackType, disclaimer, onFeedbackFormButtonClick, rep
7070

7171
return (
7272
<div>
73-
<span className={classNames('webchat__feedback-form__body1', feedbackForm + '')}>
73+
<span className={classNames('webchat__feedback-form__body', feedbackForm + '')}>
7474
{localize('FEEDBACK_FORM_TITLE')}
7575
</span>
7676
<form className={classNames('webchat__feedback-form', feedbackForm + '')} onSubmit={handleSubmit}>
@@ -82,7 +82,12 @@ function FeedbackForm({ feedbackType, disclaimer, onFeedbackFormButtonClick, rep
8282
startRows={3}
8383
value={userFeedback}
8484
/>
85-
{disclaimer && <FeedbackFormDisclaimer disclaimer={disclaimer} />}
85+
{disclaimer && (
86+
<Markdownable
87+
className={classNames('webchat__feedback-form__caption', feedbackForm + '')}
88+
text={disclaimer}
89+
/>
90+
)}
8691
<div className={classNames('webchat__feedback-form__container', feedbackForm + '')}>
8792
<button className={classNames('webchat__feedback-form__button__submit', feedbackForm + '')} type="submit">
8893
{localize('FEEDBACK_FORM_SUBMIT_BUTTON_LABEL')}

packages/component/src/Activity/private/FeedbackFormDisclaimer.tsx

Lines changed: 0 additions & 22 deletions
This file was deleted.
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
import React, { memo, useMemo } from 'react';
2+
import { useRenderMarkdownAsHTML } from '../../../hooks';
3+
4+
type MarkdownableProps = Readonly<{
5+
className?: string | undefined;
6+
text: string;
7+
}>;
8+
9+
function Markdownable({ className, text }: MarkdownableProps) {
10+
const renderMarkdownAsHTML = useRenderMarkdownAsHTML('message activity');
11+
12+
const innerHTML = useMemo<Readonly<{ __html: string }> | undefined>(
13+
() => Object.freeze({ __html: renderMarkdownAsHTML?.(text) }),
14+
[text, renderMarkdownAsHTML]
15+
);
16+
17+
return innerHTML ? (
18+
// eslint-disable-next-line react/no-danger
19+
<span className={className} dangerouslySetInnerHTML={innerHTML} />
20+
) : (
21+
<span className={className}>{text}</span>
22+
);
23+
}
24+
25+
export default memo(Markdownable);
26+
export { type MarkdownableProps };

packages/component/src/Styles/StyleSet/FeedbackForm.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ export default function createFeedbackFormStyle() {
1717
gridTemplateRows: 'auto auto',
1818
position: 'relative'
1919
},
20-
'&.webchat__feedback-form__body1': {
20+
'&.webchat__feedback-form__body': {
2121
fontFamily: CSSTokens.FontPrimary,
2222
fontStyle: 'normal',
2323
fontWeight: 400,
2424
fontSize: '14px',
2525
lineHeight: '20px',
2626
color: '#373435'
2727
},
28-
'&.webchat__feedback-form__caption1': {
28+
'&.webchat__feedback-form__caption': {
2929
fontFamily: CSSTokens.FontPrimary,
3030
fontStyle: 'normal',
3131
fontWeight: 400,

packages/fluent-theme/src/components/theme/Theme.module.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -630,15 +630,15 @@
630630
}
631631

632632
/* Feedback Form */
633-
:global(.webchat-fluent).theme :global(.webchat__feedback-form__body1) {
633+
:global(.webchat-fluent).theme :global(.webchat__feedback-form__body) {
634634
font-family: var(--webchat-fontFamilyBase);
635635
color: var(--webchat-colorNeutralForeground1);
636636
font-size: var(--webchat-fontSizeBase300);
637637
font-weight: var(--webchat-fontWeightRegular);
638638
line-height: var(--webchat-lineHeightBase300);
639639
}
640640

641-
:global(.webchat-fluent).theme :global(.webchat__feedback-form__caption1) {
641+
:global(.webchat-fluent).theme :global(.webchat__feedback-form__caption) {
642642
font-family: var(--webchat-fontFamilyBase);
643643
color: var(--webchat-colorNeutralForeground1);
644644
font-size: var(--webchat-fontSizeBase100);

0 commit comments

Comments
 (0)