fix format we are sending feedback in

lexi-taylor · lexi-taylor · commit 289abf521b0c · 2025-06-19T16:29:11.000Z
diff --git a/__tests__/html2/feedbackForm/behavior.changeMind.keyboard.html b/__tests__/html2/feedbackForm/behavior.changeMind.keyboard.html
@@ -116,9 +116,9 @@
             value: {
               actionName: 'feedback',
               actionValue: {
-                feedback: {
+                feedback: JSON.stringify({
                   feedbackText: 'Qui sint consequat reprehenderit aliquip esse duis.'
-                },
+                }),
                 reaction: 'like'
               }
             }
diff --git a/__tests__/html2/feedbackForm/behavior.changeMind.mouse.html b/__tests__/html2/feedbackForm/behavior.changeMind.mouse.html
@@ -109,9 +109,9 @@
             value: {
               actionName: 'feedback',
               actionValue: {
-                feedback: {
+                feedback: JSON.stringify({
                   feedbackText: 'Nostrud ad irure commodo magna pariatur aliqua.'
-                },
+                }),
                 reaction: 'dislike'
               }
             }
diff --git a/__tests__/html2/feedbackForm/feedback.form.activity.html b/__tests__/html2/feedbackForm/feedback.form.activity.html
@@ -119,9 +119,9 @@
               actionName: 'feedback',
               actionValue: {
                 reaction: 'dislike',
-                feedback: {
+                feedback: JSON.stringify({
                   feedbackText: 'Test feedback'
-                }
+                })
               }
             }
           })
diff --git a/__tests__/html2/feedbackForm/feedback.form.emptyFeedback.html b/__tests__/html2/feedbackForm/feedback.form.emptyFeedback.html
@@ -76,9 +76,9 @@
               actionName: 'feedback',
               actionValue: {
                 reaction: 'like',
-                feedback: {
+                feedback: JSON.stringify({
                   feedbackText: ''
-                }
+                })
               }
             }
           })
diff --git a/__tests__/html2/fluentTheme/defaultFeedback.activity.html b/__tests__/html2/fluentTheme/defaultFeedback.activity.html
@@ -178,9 +178,9 @@
             actionName: 'feedback',
             actionValue: {
               reaction: 'dislike',
-              feedback: {
+              feedback: JSON.stringify({
                 feedbackText: 'Test feedback'
-              }
+              })
             }
           }
         })
diff --git a/__tests__/html2/fluentTheme/feedback.form.multiple.html b/__tests__/html2/fluentTheme/feedback.form.multiple.html
@@ -108,9 +108,9 @@
               actionName: 'feedback',
               actionValue: {
                 reaction: 'like',
-                feedback: {
-                  feedbackText: expect.any(String)
-                }
+                feedback: JSON.stringify({
+                  feedbackText: 'Test feedback'
+                })
               }
             }
           })
diff --git a/packages/component/src/ActivityFeedback/providers/ActivityFeedbackComposer.tsx b/packages/component/src/ActivityFeedback/providers/ActivityFeedbackComposer.tsx
@@ -229,7 +229,7 @@ function ActivityFeedbackComposer(props: ActivityFeedbackComposerProps) {
           value: {
             actionName: 'feedback',
             actionValue: {
-              feedback: { feedbackText: feedbackText || '' },
+              feedback: JSON.stringify({ feedbackText: feedbackText || '' }),
               reaction: action['@type'] === 'LikeAction' ? 'like' : 'dislike'
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -116,9 +116,9 @@`
`116`	`116`	`value: {`
`117`	`117`	`actionName: 'feedback',`
`118`	`118`	`actionValue: {`
`119`		`- feedback: {`
	`119`	`+ feedback: JSON.stringify({`
`120`	`120`	`feedbackText: 'Qui sint consequat reprehenderit aliquip esse duis.'`
`121`		`- },`
	`121`	`+ }),`
`122`	`122`	`reaction: 'like'`
`123`	`123`	`}`
`124`	`124`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,9 @@`
`109`	`109`	`value: {`
`110`	`110`	`actionName: 'feedback',`
`111`	`111`	`actionValue: {`
`112`		`- feedback: {`
	`112`	`+ feedback: JSON.stringify({`
`113`	`113`	`feedbackText: 'Nostrud ad irure commodo magna pariatur aliqua.'`
`114`		`- },`
	`114`	`+ }),`
`115`	`115`	`reaction: 'dislike'`
`116`	`116`	`}`
`117`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,9 @@`
`119`	`119`	`actionName: 'feedback',`
`120`	`120`	`actionValue: {`
`121`	`121`	`reaction: 'dislike',`
`122`		`- feedback: {`
	`122`	`+ feedback: JSON.stringify({`
`123`	`123`	`feedbackText: 'Test feedback'`
`124`		`- }`
	`124`	`+ })`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`	`})`
Original file line number	Diff line number	Diff line change
`@@ -76,9 +76,9 @@`
`76`	`76`	`actionName: 'feedback',`
`77`	`77`	`actionValue: {`
`78`	`78`	`reaction: 'like',`
`79`		`- feedback: {`
	`79`	`+ feedback: JSON.stringify({`
`80`	`80`	`feedbackText: ''`
`81`		`- }`
	`81`	`+ })`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`	`})`
Original file line number	Diff line number	Diff line change
`@@ -178,9 +178,9 @@`
`178`	`178`	`actionName: 'feedback',`
`179`	`179`	`actionValue: {`
`180`	`180`	`reaction: 'dislike',`
`181`		`- feedback: {`
	`181`	`+ feedback: JSON.stringify({`
`182`	`182`	`feedbackText: 'Test feedback'`
`183`		`- }`
	`183`	`+ })`
`184`	`184`	`}`
`185`	`185`	`}`
`186`	`186`	`})`
Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,9 @@`
`108`	`108`	`actionName: 'feedback',`
`109`	`109`	`actionValue: {`
`110`	`110`	`reaction: 'like',`
`111`		`- feedback: {`
`112`		`- feedbackText: expect.any(String)`
`113`		`- }`
	`111`	`+ feedback: JSON.stringify({`
	`112`	`+ feedbackText: 'Test feedback'`
	`113`	`+ })`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`	`})`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ function ActivityFeedbackComposer(props: ActivityFeedbackComposerProps) {`
`229`	`229`	`value: {`
`230`	`230`	`actionName: 'feedback',`
`231`	`231`	`actionValue: {`
`232`		`- feedback: { feedbackText: feedbackText \|\| '' },`
	`232`	`+ feedback: JSON.stringify({ feedbackText: feedbackText \|\| '' }),`
`233`	`233`	`reaction: action['@type'] === 'LikeAction' ? 'like' : 'dislike'`
`234`	`234`	`}`
`235`	`235`	`}`