Skip to content

Commit 43d5b5c

Browse files
compulimOEvgeny
andauthored
Add attachment bar for preview upload (#5464)
* Upgrade tests * Use test ID * Adding attachment bar * Upload multiple files * Rename * Add more text-only test case * Add text only style * Scroll into view * Allow container/media query and custom variables * Fit and finish * Trim bar padding * Support reduced motion * Add escape key focus * Add tests * Add file preview thumbnail * Refactor styleSet * Bigger delete icon * Add test for ESCAPE key * Add test for delete button * Fix extra bottom padding * Add test for delete in text mode * Focus on text box after attachment is deleted * Add clear after send test * No line break * 16x16 icon * Add accessibility labels * Add styleOptions * Rename to as-list-item and as-thumbnail * Fix padding * Use test ID * Clean up * Add entry * Add issue number * Fix class naem * Add styleOptions.sendBoxAttachmentBarMaxHeight * Update PR number * Make attachment bar full width * Fix test * Fix empty attachment bar * Add preview * Fix flaky test * Fix screenshot for full-width attachment bar * Fix screenshot for full-width attachment bar * Remove propTypes * Update prop checking * Upgrade to valibot for props validation * Fix flaky * Add dark mode test for delete button * Incorporate suggestions * Use #region/#endregion * Remove center after move to masker * Remove display: content * Adds <ModdableIcon> * Use moddable icon * Use icon size * Move attachment bar to top * Fix test for moving attachment bar above send box * Fix test * Fix button size * Fix delete icon size * Add achievement --------- Co-authored-by: Eugene <EOlonov@gmail.com>
1 parent 0230b9a commit 43d5b5c

File tree

85 files changed

+1713
-48
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+1713
-48
lines changed

ACHIEVEMENTS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@ A curated list of major achievements by the Web Chat team. This document celebra
4545

4646
## 🎨 UI & Theming
4747

48+
### 📎 Attachment Preview for `sendAttachmentOn: "send"`
49+
50+
**Goal:** Improve multi-file upload UX by introducing persistent attachment previews.
51+
**By:** [@compulim](https://github.com/compulim) in [PR #5464](https://github.com/microsoft/BotFramework-WebChat/pull/5464)
52+
53+
- Added `SendBoxAttachmentBar` to allow users to preview and remove attachments before sending.
54+
- Previews switch between thumbnails and list mode based on count and accessibility settings.
55+
- Enhances multi-folder upload workflows and aligns with modern messaging UX.
56+
4857
### 🧾 Code Block Rendering & Highlighting System
4958

5059
**Goal:** Unify and polish code block rendering across Markdown and UI components.

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
9292
- Existing behavior will be kept and activities will be grouped by `sender` followed by `status`
9393
- `useGroupActivitiesByName` is favored over the existing `useGroupActivities` hook for performance reason
9494
- Middleware which support the new grouping name init argument should only compute the grouping if they match the grouping name, or the grouping name is not specified, otherwise, should do nothing and call the downstream middleware
95+
- Resolved [#5463](https://github.com/microsoft/BotFramework-WebChat/issues/5463). Added attachment preview for `sendAttachmentOn: "send"`, in PR [#5464](https://github.com/microsoft/BotFramework-WebChat/pull/5464), by [@compulim](https://github.com/compulim)
96+
- Attaching files will no longer remove previously attached files
9597

9698
### Changed
9799

Loading
Loading
Loading
516 KB
Loading

0 commit comments

Comments
 (0)