Skip to content

Commit 4e07ca8

Browse files
compulimcompulim
authored
Remove role attribute for notification bar and use <div> instead of <ul>/<li> (#4475)
* Fix notification bar role * Upgrade to HTML tests * Add entry
1 parent db38eff commit 4e07ca8

41 files changed

Lines changed: 590 additions & 446 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
2525
### Fixed
2626

2727
- Card action image alt text should use `imageAltText` field and fallback to `text` field, by [@compulim](https://github.com/compulim) in PR [#4333](https://github.com/microsoft/BotFramework-WebChat/pull/4333)
28+
- Fixes [#4472](https://github.com/microsoft/BotFramework-WebChat/issues/4472). Removed `role` attributes for notification bar and use `<div>` instead of `<ul>`/`<li>`, by [@compulim](https://github.com/compulim) in PR [#4475](https://github.com/microsoft/BotFramework-WebChat/pull/4475)
2829

2930
### Changed
3031

__tests__/__image_snapshots__/chrome-docker/toast-js-show-a-notification-update-and-dismiss-it-1-snap.png renamed to __tests__/__image_snapshots__/html/toast-show-update-dismiss-js-notification-toast-show-a-notification-update-and-dismiss-it-1-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toast-js-show-a-notification-update-and-dismiss-it-2-snap.png renamed to __tests__/__image_snapshots__/html/toast-show-update-dismiss-js-notification-toast-show-a-notification-update-and-dismiss-it-2-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toast-js-show-a-notification-update-and-dismiss-it-3-snap.png renamed to __tests__/__image_snapshots__/html/toast-show-update-dismiss-js-notification-toast-show-a-notification-update-and-dismiss-it-3-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toast-js-show-two-very-long-notifications-1-snap.png renamed to __tests__/__image_snapshots__/html/toast-two-very-long-notifications-js-notification-toast-show-two-very-long-notifications-1-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toast-js-show-two-very-long-notifications-2-snap.png renamed to __tests__/__image_snapshots__/html/toast-two-very-long-notifications-js-notification-toast-show-two-very-long-notifications-2-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toast-js-show-two-very-long-notifications-3-snap.png renamed to __tests__/__image_snapshots__/html/toast-two-very-long-notifications-js-notification-toast-show-two-very-long-notifications-3-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toaster-js-hide-toaster-1-snap.png renamed to __tests__/__image_snapshots__/html/toaster-hide-toaster-js-notification-toast-hide-toaster-1-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toaster-js-hide-toaster-2-snap.png renamed to __tests__/__image_snapshots__/html/toaster-hide-toaster-js-notification-toast-hide-toaster-2-snap.png

File renamed without changes.

__tests__/__image_snapshots__/chrome-docker/toaster-js-hide-toaster-3-snap.png renamed to __tests__/__image_snapshots__/html/toaster-hide-toaster-js-notification-toast-hide-toaster-3-snap.png

File renamed without changes.

0 commit comments

Comments
 (0)