Skip to content

Commit 5e12798

Browse files
lexi-taylorcompulimOEvgeny
authored
Feedback Form Bugs: Not rendering markdown and feedback button click not persisting (#5470)
* initial commit * revert changes and new snapshots * add feedback markdown rendering * update changelog * updating snapshot * fix test * Update packages/component/src/Activity/private/FeedbackForm.tsx Co-authored-by: William Wong <compulim@users.noreply.github.com> * Update packages/component/src/Activity/private/FeedbackForm.tsx Co-authored-by: William Wong <compulim@users.noreply.github.com> * temp changes * fixes * fix tests * update accidental test changes * update based on discussion * update display none * update nits * move tooltip to variable * Update packages/component/src/Styles/StyleSet/ThumbButton.ts Co-authored-by: Eugene <EOlonov@gmail.com> * add option to hide feedbackform * Revert "add option to hide feedbackform" This reverts commit c39f110. * use suggestions * A few tweaks * Unskip the actions update on changing selected * Preserve initial action * Resolve selectedAction type before passing to useMemo * Unwind the reset/submit logic * change source of truth to feedbackactions * suggestions * remove unnedded newline * refactor feedback loop logic into it's own component * fix failing test * Add readonly * Prettier * remove ...entities * Single source of truth * Fix test * Improve styles * Snaps * Fix resubmission logic * Restrict tooltip changes to large button * More snaps * More snaps * More snaps * More snaps * More snaps * Fix test * Fix tests * Fix test * Fix tests * Wait until scroll completed * More snaps * Revert "More snaps" This reverts commit f0210f8. * Update like/dislike to have accent color * fix width of feedback form * Update packages/component/src/Styles/StyleSet/FeedbackForm.ts Co-authored-by: Eugene <EOlonov@gmail.com> --------- Co-authored-by: William Wong <compulim@users.noreply.github.com> Co-authored-by: Eugene <EOlonov@gmail.com>
1 parent 41e8175 commit 5e12798

File tree

101 files changed

+1208
-736
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+1208
-736
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
8585
- Added support of [contentless activity in livestream](https://github.com/microsoft/BotFramework-WebChat/blob/main/docs/LIVESTREAMING.md#scenario-3-interim-activities-with-no-content), in PR [#5430](https://github.com/microsoft/BotFramework-WebChat/pull/5430), by [@compulim](https://github.com/compulim)
8686
- Added sliding dots typing indicator in Fluent theme, in PR [#5447](https://github.com/microsoft/BotFramework-WebChat/pull/5447) and PR [#5448](https://github.com/microsoft/BotFramework-WebChat/pull/5448), by [@compulim](https://github.com/compulim)
8787
- (Experimental) Add an ability to pass `completion` prop into Fluent send box and expose the component, in PR [#5466](https://github.com/microsoft/BotFramework-WebChat/pull/5466), by [@OEvgeny](https://github.com/OEvgeny)
88-
- Added feedback form for like/dislike button when `feedbackActionsPlacement` is `"activity-actions"`, in PR [#5460](https://github.com/microsoft/BotFramework-WebChat/pull/5460) and in PR [#5469](https://github.com/microsoft/BotFramework-WebChat/pull/5469), by [@lexi-taylor](https://github.com/lexi-taylor) and [@OEvgeny](https://github.com/OEvgeny)
88+
- Added feedback form for like/dislike button when `feedbackActionsPlacement` is `"activity-actions"`, in PR [#5460](https://github.com/microsoft/BotFramework-WebChat/pull/5460), PR [#5469](https://github.com/microsoft/BotFramework-WebChat/pull/5469), and PR [5470](https://github.com/microsoft/BotFramework-WebChat/pull/5470) by [@lexi-taylor](https://github.com/lexi-taylor) and [@OEvgeny](https://github.com/OEvgeny)
8989

9090
### Changed
9191

1014 Bytes
Loading
1.49 KB
Loading
1017 Bytes
Loading
1000 Bytes
Loading
1.47 KB
Loading
1.47 KB
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)