review comment fixed

Author: pranavjoshi001

docs/CAPABILITIES.md

@@ -1,6 +1,6 @@
 # Capabilities
 
-Web Chat supports dynamic capability discovery from adapters. Capabilities allow adapters to expose configuration values that WebChat components can consume and react to changes.
+Web Chat supports dynamic capability discovery from adapters. Capabilities allow adapters to expose configuration values that Web Chat components can consume and react to changes.
 
 ## Using the hook
 
@@ -22,9 +22,9 @@ if (voiceConfig) {
 
 ## Available capabilities
 
-| Capability | Type | Description |
-|------------|------|-------------|
-| `voiceConfiguration` | `{ sampleRate: number, chunkIntervalMs: number }` | Audio settings for Speech-to-Speech |
+| Capability           | Type                                               | Description                         |
+| -------------------- | -------------------------------------------------- | ----------------------------------- |
+| `voiceConfiguration` | `{ chunkIntervalMs: number, sampleRate: number }`  | Audio settings for Speech-to-Speech |
 
 ## How it works
 

packages/api/src/providers/Capabilities/CapabilitiesComposer.tsx

@@ -46,6 +46,7 @@ const CapabilitiesComposer = memo(({ children }: Props) => {
     [activities]
   );
 
+  // TODO: [P1] update to use EventTarget than activity$.
   const capabilities = useReduceMemo(
     activitiesWithInit,
     useCallback(

packages/api/src/providers/Capabilities/private/fetchCapabilitiesFromAdapter.ts

@@ -37,13 +37,13 @@ export default function fetchCapabilitiesFromAdapter(
         const prevValue = prevCapabilities[key];
 
         if (fetchedValue) {
-          if (prevValue !== undefined && isEqual(prevValue, fetchedValue)) {
+          if (typeof prevValue !== 'undefined' && isEqual(prevValue, fetchedValue)) {
             entries.push([key, prevValue]);
           } else {
             entries.push([key, Object.freeze({ ...fetchedValue })]);
             hasChanged = true;
           }
-        } else if (prevValue !== undefined) {
+        } else if (typeof prevValue !== 'undefined') {
           hasChanged = true;
         }
       } catch (error) {

packages/api/src/providers/Capabilities/private/shallowEqual.ts

@@ -1,5 +1,6 @@
 import { isForbiddenPropertyName } from 'botframework-webchat-core';
 
+// TODO: [P2] Move this file to `base` package.
 export default function shallowEqual(x, y) {
   if (x === y) {
     return true;

packages/api/src/providers/Capabilities/types/Capabilities.ts

@@ -9,8 +9,8 @@ type Capabilities = Readonly<{
  * Optional for adapter/server to provide these configs for speech-to-speech.
  */
 type VoiceConfiguration = Readonly<{
-  sampleRate: number;
   chunkIntervalMs: number;
+  sampleRate: number;
 }>;
 
 export type { Capabilities, VoiceConfiguration };