Skip to content

Commit 8b2e27a

Browse files
committed
add eslint disables
1 parent 40bc80e commit 8b2e27a

3 files changed

Lines changed: 21 additions & 5 deletions

File tree

packages/component/src/ActivityFeedback/private/FeedbackForm.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,14 @@ function FeedbackForm() {
4747

4848
return (
4949
<div className={classNames['feedback-form__form']}>
50-
<span className={classNames['feedback-form__form-header']} id={feedbackFormHeaderId}>{localize('FEEDBACK_FORM_TITLE')}</span>
50+
<span
51+
className={classNames['feedback-form__form-header']}
52+
// "id" is required for "aria-labelledby"
53+
// eslint-disable-next-line react/forbid-dom-props
54+
id={feedbackFormHeaderId}
55+
>
56+
{localize('FEEDBACK_FORM_TITLE')}
57+
</span>
5158
<div className={classNames['feedback-form__text-box']}>
5259
<TextArea
5360
aria-label={localize('FEEDBACK_FORM_PLACEHOLDER')}
@@ -62,7 +69,9 @@ function FeedbackForm() {
6269
value={userFeedback}
6370
/>
6471
</div>
65-
{disclaimer && <Markdownable id={disclaimerId} className={classNames['feedback-form__form-footer']} text={disclaimer} />}
72+
{disclaimer && (
73+
<Markdownable className={classNames['feedback-form__form-footer']} id={disclaimerId} text={disclaimer} />
74+
)}
6675
<div className={classNames['feedback-form__submission-button-bar']}>
6776
<button className={classNames['feedback-form__submit-button']} type="submit">
6877
{localize('FEEDBACK_FORM_SUBMIT_BUTTON_LABEL')}

packages/component/src/Attachment/Text/private/Markdownable.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,15 @@ function Markdownable({ className, text, id }: MarkdownableProps) {
2323
);
2424

2525
return innerHTML ? (
26-
// eslint-disable-next-line react/no-danger
27-
<span id={id} className={className} dangerouslySetInnerHTML={innerHTML} />
26+
// "id" is required for "aria-labelledby"
27+
// eslint-disable-next-line react/forbid-dom-props, react/no-danger
28+
<span className={className} dangerouslySetInnerHTML={innerHTML} id={id} />
2829
) : (
29-
<span id={id} className={className}>{text}</span>
30+
// "id" is required for "aria-labelledby"
31+
// eslint-disable-next-line react/forbid-dom-props
32+
<span className={className} id={id}>
33+
{text}
34+
</span>
3035
);
3136
}
3237

packages/component/src/TextArea/TextArea.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ const TextArea = forwardRef<
9090
aria-labelledby={props['aria-labelledby']}
9191
className={cx(classNames['text-area-input'], classNames['text-area-shared'])}
9292
data-testid={props['data-testid']}
93+
// "id" is required for "aria-labelledby"
94+
// eslint-disable-next-line react/forbid-dom-props
9395
id={props['id']}
9496
onCompositionEnd={handleCompositionEnd}
9597
onCompositionStart={handleCompositionStart}

0 commit comments

Comments
 (0)