Skip to content

Commit 911887a

Browse files
OEvgenycompulim
andauthored
Apply suggestions from code review
Co-authored-by: William Wong <compulim@users.noreply.github.com>
1 parent 4a2c178 commit 911887a

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1352,7 +1352,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
13521352
- Fixes [#3750](https://github.com/microsoft/BotFramework-WebChat/issues/3750). Debump Node.js engines requirements for some packages to `12.0.0`, by [@compulim](https://github.com/compulim) in PR [#3753](https://github.com/microsoft/BotFramework-WebChat/pull/3753)
13531353
- Fixes [#3760](https://github.com/microsoft/BotFramework-WebChat/issues/3760). Use `<ErrorBoundary>` to wrap around attachment renderer, by [@compulim](https://github.com/compulim) in PR [#3761](https://github.com/microsoft/BotFramework-WebChat/pull/3761)
13541354
- Fixes [#3764](https://github.com/microsoft/BotFramework-WebChat/issues/3764). Added `role="group"` to the focusable transcript to enable `aria-activedescendant`, by [@compulim](https://github.com/compulim) in PR [#3765](https://github.com/microsoft/BotFramework-WebChat/issues/3765)
1355-
- Fixed adaptive card re-rendering can cause layout shift, by [@OEvgeny](https://github.com/OEvgeny), in PR [#5494](https://github.com/microsoft/BotFramework-WebChat/issues/5494)
1355+
- Fixed re-rendering Adaptive Card should not cause momentarily layout shift, by [@OEvgeny](https://github.com/OEvgeny), in PR [#5494](https://github.com/microsoft/BotFramework-WebChat/issues/5494)
13561356

13571357
### Changed
13581358

__tests__/html2/adaptiveCard/rerender.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171

7272
await new Promise(resolve => setTimeout(resolve, 200));
7373

74-
let observedMutations
74+
let observedMutations;
7575
new MutationObserver((mutations) => {
7676
observedMutations = mutations;
7777
}).observe(adaptiveCardEl, { childList: true });

0 commit comments

Comments
 (0)