Skip to content

Commit 91565ef

Browse files
committed
Relax upsert conflict checks
1 parent b4e565d commit 91565ef

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,7 @@ Breaking changes in this release:
384384
- Fixed activity sorting introduced in PR [#5622](https://github.com/microsoft/BotFramework-WebChat/pull/5622), part grouping, and livestreaming, by [@compulim](https://github.com/compulim) in PR [#5635](https://github.com/microsoft/BotFramework-WebChat/pull/5635)
385385
- Fixed Content Security Policy documentation and sample in PR, by [@compulim](https://github.com/compulim) in PR [#5648](https://github.com/microsoft/BotFramework-WebChat/pull/5648)
386386
- Added `img-src data:`, required for icons
387+
- Downgraded graph upsert conflict checks, by [@compulim](https://github.com/compulim) in PR [#XXX](https://github.com/microsoft/BotFramework-WebChat/pull/XXX)
387388

388389
## [4.18.0] - 2024-07-10
389390

packages/core-graph/src/private/Graph.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class Graph<TInput extends GraphNode, TOutput extends GraphNode = TInput> implem
9090
const id = node['@id'];
9191

9292
if (upsertedNodes.has(id)) {
93-
throw new Error(`Cannot upsert a node multiple times in a single transaction (@id = "${id}")`);
93+
console.warn(`botframework-webchat: Should NOT upsert a node multiple times in a single transaction (@id = "${id}")`);
9494
}
9595

9696
upsertedNodes.set(id, node);

0 commit comments

Comments
 (0)