Skip to content

Commit 97c68f4

Browse files
committed
refactor
1 parent 0e4c38d commit 97c68f4

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

packages/component/src/Activity/ActivityFeedback.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ const parseActivity = (entities?: WebChatActivity['entities']) => {
3636
const useGetMessageThing = (activity: WebChatActivity) =>
3737
useMemo(() => {
3838
const { messageThing, graph } = parseActivity(activity.entities);
39-
if (messageThing?.potentialAction) {
40-
return { isFeedbackLoopSupported: false, messageThing, graph };
41-
} else if (isDefaultFeedbackActivity(activity)) {
39+
if (isDefaultFeedbackActivity(activity)) {
4240
return { isFeedbackLoopSupported: true, ...parseActivity([defaultFeedbackEntities]) };
4341
}
4442
return { isFeedbackLoopSupported: false, messageThing, graph };
@@ -52,8 +50,6 @@ function ActivityFeedback({ activity }: ActivityFeedbackProps) {
5250
const [feedbackType, setFeedbackType] = useState<string | undefined>(undefined);
5351
const resetFeedbackRef = useRef<() => void>();
5452

55-
const { id } = activity;
56-
5753
const { messageThing, graph, isFeedbackLoopSupported } = useGetMessageThing(activity);
5854

5955
const feedbackActions = useMemo<ReadonlySet<OrgSchemaAction>>(() => {
@@ -114,10 +110,10 @@ function ActivityFeedback({ activity }: ActivityFeedbackProps) {
114110
disclaimer={disclaimer}
115111
feedbackType={feedbackType as FeedbackType}
116112
handeFeedbackTypeChange={onFeedbackTypeChange}
117-
replyToId={id}
113+
replyToId={activity.id}
118114
/>
119115
),
120-
[disclaimer, feedbackType, id, onFeedbackTypeChange]
116+
[activity.id, disclaimer, feedbackType, onFeedbackTypeChange]
121117
);
122118

123119
if (feedbackActionsPlacement === 'activity-actions' && isFeedbackLoopSupported) {

0 commit comments

Comments
 (0)