File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 44
55### General
66
7+ - Read ` docs/CONTRIBUTING.md ` for details on setting up the repository for development
78- Unless stated otherwise, avoid Node.js
89- Apply our latest coding style to every file changed
910- Avoid spaghetti code: on new feature with a similar existing feature, refactor existing one before writing new feature
2324- Prefer uppercase for acronyms instead of Pascal case, e.g. ` getURL() ` over ` getUrl() `
2425 - The only exception is ` id ` , e.g. ` getId() ` over ` getID() `
2526- Use fewer shorthands, only allow ` min ` , ` max ` , ` num `
27+ - All new/changed production code must have test cases, look at ` __tests__/html2/** `
28+ - Code coverage for new/changed code should reach 80%
29+ - Deprecation notes should mark the date as 2 years from now
2630
2731### Design
2832
4852- Use ` { readonly value: string } ` instead of ` Readonly<{ value: string }> `
4953- Use as much ` readonly ` as possible
5054
51- ### React template
55+ ### React
56+
57+ - Always add ` displayName `
58+
59+ Follow the template below.
5260
5361``` tsx
5462import { reactNode , validateProps } from ' @msinternal/botframework-webchat-react-valibot' ;
You can’t perform that action at this time.
0 commit comments