Skip to content

Commit b758ff8

Browse files
authored
Clean up legacy test framework (#5655)
* Hide squiggles * Remove obsoleted screenshots * Clean up legacy test framework * Fix append ID * Update localization doc * Merge LOCALIZATION.md * Move back to 18 * Fix path * Default to html2 * Add entry * Add achievement * Revert missing snapshot * Put Babel config inside esbuild profiling config * Hide squiggles * Revert "Put Babel config inside esbuild profiling config" This reverts commit 76f4d6e. * Rename * Set eslint-env * Clean up * Remove jest-junit and jest-trx-results-processor
1 parent 9da963d commit b758ff8

138 files changed

Lines changed: 271 additions & 2090 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/pull-request-validation.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ jobs:
145145
--forceExit \
146146
--logHeapUsage \
147147
--runInBand \
148+
--silent \
148149
--testPathPattern=/packages/\
149150
timeout-minutes: 10
150151

@@ -154,7 +155,7 @@ jobs:
154155
ls -laR .
155156
156157
mv lcov.info lcov-unit.info
157-
mv result.trx result-unit.trx
158+
# mv result.trx result-unit.trx
158159
working-directory: ./coverage
159160

160161
- if: always()
@@ -164,7 +165,7 @@ jobs:
164165
name: test-result-unit
165166
path: |
166167
./coverage/lcov-*.info
167-
./coverage/result-*.trx
168+
# ./coverage/result-*.trx
168169

169170
type-definitions-test:
170171
name: Type definitions test
@@ -255,7 +256,8 @@ jobs:
255256
--forceExit \
256257
--logHeapUsage \
257258
--runInBand \
258-
--shard=${{ format('{0}/{1}', matrix.shard-index, matrix.shard-count) }}
259+
--shard=${{ format('{0}/{1}', matrix.shard-index, matrix.shard-count) }} \
260+
--silent
259261
timeout-minutes: 10
260262

261263
- if: always()
@@ -268,7 +270,7 @@ jobs:
268270
ls -laR .
269271
270272
mv lcov.info lcov-${{ matrix.shard-index }}.info
271-
mv result.trx result-${{ matrix.shard-index }}.trx
273+
# mv result.trx result-${{ matrix.shard-index }}.trx
272274
working-directory: ./coverage
273275

274276
- if: always()
@@ -278,7 +280,7 @@ jobs:
278280
name: test-result-html-${{ matrix.shard-index }}
279281
path: |
280282
./coverage/lcov-*.info
281-
./coverage/result-*.trx
283+
# ./coverage/result-*.trx
282284

283285
- if: failure()
284286
name: Upload test snapshot diffs

ACHIEVEMENTS.md

Lines changed: 29 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ A curated list of major achievements by the Web Chat team. This document celebra
44

55
<!-- Template for future additions. Add new to the top of a corresponding section.
66
7-
## 🏆 \[Achievement Title]
7+
### 🏆 \[Achievement Title]
88
99
**Goal:** Briefly describe the purpose of the change.
1010
**By:** [@username](https://github.com/username) in [PR #XXXX](https://github.com/microsoft/BotFramework-WebChat/pull/XXXX)
@@ -19,7 +19,7 @@ A curated list of major achievements by the Web Chat team. This document celebra
1919

2020
### 🌐 ES Modules Browser Build
2121

22-
**Goal:** Ship first-class `<script type="module">` bundles for modern browsers.
22+
**Goal:** Ship first-class `<script type="module">` bundles for modern browsers.
2323
**By:** [@compulim](https://github.com/compulim) in [PR #5592](https://github.com/microsoft/BotFramework-WebChat/pull/5592), [#5593](https://github.com/microsoft/BotFramework-WebChat/pull/5593), [#5595](https://github.com/microsoft/BotFramework-WebChat/pull/5595), [#5600](https://github.com/microsoft/BotFramework-WebChat/pull/5600), [#5602](https://github.com/microsoft/BotFramework-WebChat/pull/5602)
2424

2525
- Delivered browser-ready ES module builds with vendor chunking for optimal caching.
@@ -28,7 +28,7 @@ A curated list of major achievements by the Web Chat team. This document celebra
2828

2929
### 🧠 Part Grouping for Chain-of-Thought
3030

31-
**Goal:** Organize multi-part reasoning flows into collapsible groups within the transcript.
31+
**Goal:** Organize multi-part reasoning flows into collapsible groups within the transcript.
3232
**By:** [@OEvgeny](https://github.com/OEvgeny) in [PR #5553](https://github.com/microsoft/BotFramework-WebChat/pull/5553), [#5585](https://github.com/microsoft/BotFramework-WebChat/pull/5585), [#5590](https://github.com/microsoft/BotFramework-WebChat/pull/5590), [#5608](https://github.com/microsoft/BotFramework-WebChat/pull/5608)
3333

3434
- Added logical grouping and context so activities can self-organize via `Message` entity metadata.
@@ -38,23 +38,23 @@ A curated list of major achievements by the Web Chat team. This document celebra
3838

3939
### 🛠️ Migration to `micromark`
4040

41-
**Goal:** Replace `markdown-it` with a modern and extensible markdown parser.
41+
**Goal:** Replace `markdown-it` with a modern and extensible markdown parser.
4242
**By:** [@compulim](https://github.com/compulim) in [PR #5330](https://github.com/microsoft/BotFramework-WebChat/pull/5330)
4343

4444
- Switched to `micromark`, enabling MathML support and consistent parsing.
4545
- Foundation for better Markdown extensibility and performance.
4646

4747
### 🧼 HTML Content Transformer Middleware
4848

49-
**Goal:** Move HTML sanitization into a dedicated middleware layer.
49+
**Goal:** Move HTML sanitization into a dedicated middleware layer.
5050
**By:** [@compulim](https://github.com/compulim) in [PR #5338](https://github.com/microsoft/BotFramework-WebChat/pull/5338)
5151

5252
- Clean separation of concerns for Markdown rendering and sanitation.
5353
- Easier customization and more secure rendering.
5454

5555
### 🧩 Migration to npm Workspaces
5656

57-
**Goal:** Modernize monorepo tooling for better dependency and package management.
57+
**Goal:** Modernize monorepo tooling for better dependency and package management.
5858
**By:** [@compulim](https://github.com/compulim) in [PR #5301](https://github.com/microsoft/BotFramework-WebChat/pull/5301)
5959

6060
- Dropped Lerna in favor of native npm workspaces.
@@ -66,15 +66,15 @@ A curated list of major achievements by the Web Chat team. This document celebra
6666

6767
### 🎨 Icon Customization via CSS Variables
6868

69-
**Goal:** Enable developers to customize Web Chat and Fluent theme icons without JavaScript overrides.
69+
**Goal:** Enable developers to customize Web Chat and Fluent theme icons without JavaScript overrides.
7070
**By:** [@OEvgeny](https://github.com/OEvgeny) in [PR #5413](https://github.com/microsoft/BotFramework-WebChat/pull/5413), [#5502](https://github.com/microsoft/BotFramework-WebChat/pull/5502)
7171

7272
- Introduced CSS variable-based icon customization system for Web Chat and Fluent theme.
7373
- Reworked existing icons and fully enabled across Web Chat components.
7474

7575
### 📎 Attachment Preview for `sendAttachmentOn: "send"`
7676

77-
**Goal:** Improve multi-file upload UX by introducing persistent attachment previews.
77+
**Goal:** Improve multi-file upload UX by introducing persistent attachment previews.
7878
**By:** [@compulim](https://github.com/compulim), [@OEvgeny](https://github.com/OEvgeny) in [PR #5464](https://github.com/microsoft/BotFramework-WebChat/pull/5464), [#5491](https://github.com/microsoft/BotFramework-WebChat/pull/5491), [#5492](https://github.com/microsoft/BotFramework-WebChat/pull/5492)
7979

8080
- Added `SendBoxAttachmentBar` to allow users to preview and remove attachments before sending.
@@ -83,7 +83,7 @@ A curated list of major achievements by the Web Chat team. This document celebra
8383

8484
### 🧾 Code Block Rendering & Highlighting System
8585

86-
**Goal:** Unify and polish code block rendering across Markdown and UI components.
86+
**Goal:** Unify and polish code block rendering across Markdown and UI components.
8787
**By:** [@OEvgeny](https://github.com/OEvgeny), [@compulim](https://github.com/compulim) in [PR #5334](https://github.com/microsoft/BotFramework-WebChat/pull/5334), [#5335](https://github.com/microsoft/BotFramework-WebChat/pull/5335), [#5336](https://github.com/microsoft/BotFramework-WebChat/pull/5336), [#5389](https://github.com/microsoft/BotFramework-WebChat/pull/5389)
8888

8989
- Introduced syntax highlighting for markdown blocks using Shiki.
@@ -92,23 +92,23 @@ A curated list of major achievements by the Web Chat team. This document celebra
9292

9393
### ✨ Fluent Theme Overhaul
9494

95-
**Goal:** Expand and refine Fluent UI styling across all components.
95+
**Goal:** Expand and refine Fluent UI styling across all components.
9696
**By:** [@OEvgeny](https://github.com/OEvgeny) in [PR #5258](https://github.com/microsoft/BotFramework-WebChat/pull/5258) and others
9797

9898
- Introduced "Copilot" variant and transcript-wide theming.
9999
- Improved accessibility, visual consistency, and component modularity.
100100

101101
### 🧱 Decorator System for Activity Styling
102102

103-
**Goal:** Enable pluggable, dynamic visual enhancements per activity.
103+
**Goal:** Enable pluggable, dynamic visual enhancements per activity.
104104
**By:** [@OEvgeny](https://github.com/OEvgeny) in [PR #5205](https://github.com/microsoft/BotFramework-WebChat/pull/5205), [#5312](https://github.com/microsoft/BotFramework-WebChat/pull/5312)
105105

106106
- Introduced `WebChatDecorator` and `ActivityDecorator`.
107107
- Supports animated borders and style options with minimal code changes.
108108

109109
### 🗂️ Starter Prompts
110110

111-
**Goal:** Enhance onboarding by offering users suggested starter prompts before interaction.
111+
**Goal:** Enhance onboarding by offering users suggested starter prompts before interaction.
112112
**By:** [@compulim](https://github.com/compulim), [@OEvgeny](https://github.com/OEvgeny)
113113

114114
- Experimental pre-chat messages added in [PR #5255](https://github.com/microsoft/BotFramework-WebChat/pull/5255) and [#5263](https://github.com/microsoft/BotFramework-WebChat/pull/5263)
@@ -120,15 +120,15 @@ A curated list of major achievements by the Web Chat team. This document celebra
120120

121121
### 🎙️ Speech Recognition Enhancements
122122

123-
**Goal:** Improve real-world usability of voice input.
123+
**Goal:** Improve real-world usability of voice input.
124124
**By:** [@compulim](https://github.com/compulim), [@RushikeshGavali](https://github.com/RushikeshGavali) in [PR #5400](https://github.com/microsoft/BotFramework-WebChat/pull/5400), [#5426](https://github.com/microsoft/BotFramework-WebChat/pull/5426)
125125

126126
- Support for initial silence timeout and continuous barge-in mode.
127127
- Makes Azure Speech more responsive and accessible.
128128

129129
### 🔊 Centralized Live Region Announcements
130130

131-
**Goal:** Improve screen reader support via centralized ARIA updates.
131+
**Goal:** Improve screen reader support via centralized ARIA updates.
132132
**By:** [@OEvgeny](https://github.com/OEvgeny) in [PR #5251](https://github.com/microsoft/BotFramework-WebChat/pull/5251)
133133

134134
- Added `usePushToLiveRegion` hook.
@@ -140,15 +140,15 @@ A curated list of major achievements by the Web Chat team. This document celebra
140140

141141
### 🧩 Shadow DOM Support
142142

143-
**Goal:** Enable safe embedding of Web Chat in custom element trees.
143+
**Goal:** Enable safe embedding of Web Chat in custom element trees.
144144
**By:** [@OEvgeny](https://github.com/OEvgeny) in [PR #5196](https://github.com/microsoft/BotFramework-WebChat/pull/5196)
145145

146146
- Added `stylesRoot`, `ThemeProvider.styles`, and nonce support.
147147
- Ensures style encapsulation and isolation in Web Component environments.
148148

149149
### 🧮 TeX/MathML Markdown Support
150150

151-
**Goal:** Support use cases requiring math rendering.
151+
**Goal:** Support use cases requiring math rendering.
152152
**By:** [@compulim](https://github.com/compulim), [@OEvgeny](https://github.com/OEvgeny) in [PR #5332](https://github.com/microsoft/BotFramework-WebChat/pull/5332), [#5381](https://github.com/microsoft/BotFramework-WebChat/pull/5381)
153153

154154
- Integrated `katex` via `micromark-extension-math`.
@@ -160,7 +160,7 @@ A curated list of major achievements by the Web Chat team. This document celebra
160160

161161
### 🧩 Introduction of PolyMiddleware
162162

163-
**Goal:** Enable composable, reusable, and unified way for managing middleware.
163+
**Goal:** Enable composable, reusable, and unified way for managing middleware.
164164
**By:** [@compulim](https://github.com/compulim) in [PR #5515](https://github.com/microsoft/BotFramework-WebChat/pull/5515), [#5566](https://github.com/microsoft/BotFramework-WebChat/pull/5566)
165165

166166
- Allows multiple middleware to be composed and applied from a single place.
@@ -169,15 +169,15 @@ A curated list of major achievements by the Web Chat team. This document celebra
169169

170170
### 🧠 Memoization & Hook Optimizations
171171

172-
**Goal:** Reduce rerenders and memory footprint.
172+
**Goal:** Reduce rerenders and memory footprint.
173173
**By:** [@OEvgeny](https://github.com/OEvgeny), [@compulim](https://github.com/compulim) across [#5163](https://github.com/microsoft/BotFramework-WebChat/pull/5163), [#5183](https://github.com/microsoft/BotFramework-WebChat/pull/5183), [#5190](https://github.com/microsoft/BotFramework-WebChat/pull/5190)
174174

175175
- Rewrote key hooks (`useActivityWithRenderer`, `useMemoized`) for efficiency.
176176
- Prevents excessive renders in large conversations.
177177

178178
### 🧮 Multi-Dimensional Grouping Support
179179

180-
**Goal:** Improve activity grouping logic and performance.
180+
**Goal:** Improve activity grouping logic and performance.
181181
**By:** [@compulim](https://github.com/compulim) in [PR #5471](https://github.com/microsoft/BotFramework-WebChat/pull/5471)
182182

183183
- Added `styleOptions.groupActivitiesBy` and `useGroupActivitiesByName` hook.
@@ -187,10 +187,19 @@ A curated list of major achievements by the Web Chat team. This document celebra
187187

188188
### 🧪 `valibot` Props Validation
189189

190-
**Goal:** Modernize runtime prop validation for performance and clarity.
190+
**Goal:** Modernize runtime prop validation for performance and clarity.
191191
**By:** [@compulim](https://github.com/compulim) in [PR #5476](https://github.com/microsoft/BotFramework-WebChat/pull/5476)
192192

193193
- Introduced `valibot` to improve schema-based prop safety.
194194
- Reduces runtime errors and simplifies validation logic.
195195

196+
### 🧪 `html2` test infrastructure
197+
198+
**Goal:** Modernize WebDriver test infrastructure to prioritize debuggability and reproducibility.
199+
**By:** [@compulim](https://github.com/compulim) in [PR #5311](https://github.com/microsoft/BotFramework-WebChat/pull/5311), along with migrations [PR #5541](https://github.com/microsoft/BotFramework-WebChat/pull/5541), [PR #5543](https://github.com/microsoft/BotFramework-WebChat/pull/5543), [PR #5544](https://github.com/microsoft/BotFramework-WebChat/pull/5544), [PR #5545](https://github.com/microsoft/BotFramework-WebChat/pull/5545), [PR #5546](https://github.com/microsoft/BotFramework-WebChat/pull/5546), [PR #5547](https://github.com/microsoft/BotFramework-WebChat/pull/5547), [PR #5548](https://github.com/microsoft/BotFramework-WebChat/pull/5548), [PR #5549](https://github.com/microsoft/BotFramework-WebChat/pull/5549), [PR #5550](https://github.com/microsoft/BotFramework-WebChat/pull/5550), [PR #5576](https://github.com/microsoft/BotFramework-WebChat/pull/5576), [PR #5577](https://github.com/microsoft/BotFramework-WebChat/pull/5577), [PR #5649](https://github.com/microsoft/BotFramework-WebChat/pull/5649), [PR #5651](https://github.com/microsoft/BotFramework-WebChat/pull/5651), [PR #5652](https://github.com/microsoft/BotFramework-WebChat/pull/5652), [PR #5653](https://github.com/microsoft/BotFramework-WebChat/pull/5653)
200+
201+
- Eliminate `.js` entry file.
202+
- Put screenshots side-by-side with test to improve debuggability.
203+
- Improves debuggability by running tests directly in browser.
204+
196205
---

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,9 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
344344
- Use `entities[@id=""][@type="Message"].citation[@type="Claim"]` instead
345345
- `activityStatusMiddleware.nextVisibleActivity` and `activityStatusMiddleware.sameTimestampGroup` is being deprecated and will be removed on or after 2022-07-22, in PR [#4362](https://github.com/microsoft/BotFramework-WebChat/issues/4362), by [@compulim](https://github.com/compulim)
346346
- Completed deprecation, in PR [#5565](https://github.com/microsoft/BotFramework-WebChat/issues/5565), by [@compulim](https://github.com/compulim)
347+
- Removed legacy test harness, in PR [#5655](https://github.com/microsoft/BotFramework-WebChat/issues/5655), by [@compulim](https://github.com/compulim)
348+
- All tests are now either using `html2` test harness or simple unit tests
349+
- Legacy and `html` (html1) test harness are all migrated to `html2`
347350

348351
### Samples
349352

LOCALIZATION.md

Lines changed: 0 additions & 35 deletions
This file was deleted.

__tests__/.eslintrc

Lines changed: 0 additions & 8 deletions
This file was deleted.

__tests__/.prettierrc.yml

Lines changed: 0 additions & 10 deletions
This file was deleted.

__tests__/__image_snapshots__/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.
Binary file not shown.

__tests__/assets/index.css

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,12 @@ body.jest textarea,
3030
body.jest [contenteditable] {
3131
caret-color: Transparent;
3232
}
33+
34+
input::grammar-error,
35+
input::spelling-error,
36+
textarea::grammar-error,
37+
textarea::spelling-error,
38+
[contenteditable]::grammar-error,
39+
[contenteditable]::spelling-error {
40+
text-decoration: none;
41+
}

__tests__/constants.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)