Skip to content

Commit e1dc0f1

Browse files
committed
Split utils
1 parent 476ef80 commit e1dc0f1

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

packages/component/src/Activity/ActivityFeedback.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ import React, { memo, useCallback, useMemo, useState } from 'react';
55
import useStyleSet from '../hooks/useStyleSet';
66
import dereferenceBlankNodes from '../Utils/JSONLinkedData/dereferenceBlankNodes';
77
import Feedback from './private/Feedback';
8-
import { getDisclaimer, hasFeedbackLoop } from './private/feedbackActivity.util';
8+
import getDisclaimer from './private/getDisclaimer';
9+
import hasFeedbackLoop from './private/hasFeedbackLoop';
910
import FeedbackForm from './private/FeedbackForm';
1011

1112
const { useStyleOptions } = hooks;
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { type WebChatActivity } from 'botframework-webchat-core';
2+
import hasFeedbackLoop from './hasFeedbackLoop';
3+
4+
export default function getDisclaimer(activity: WebChatActivity): string | undefined {
5+
return hasFeedbackLoop(activity) ? activity.channelData.feedbackLoop.disclaimer : undefined;
6+
}

packages/component/src/Activity/private/feedbackActivity.util.ts renamed to packages/component/src/Activity/private/hasFeedbackLoop.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ const activityWithFeedbackLoopSchema = object({
1212

1313
type FeedbackActivity = WebChatActivity & InferOutput<typeof activityWithFeedbackLoopSchema>;
1414

15-
export const hasFeedbackLoop = (activity: WebChatActivity): activity is FeedbackActivity =>
16-
safeParse(activityWithFeedbackLoopSchema, activity).success;
17-
18-
export const getDisclaimer = (activity: WebChatActivity): string | undefined =>
19-
hasFeedbackLoop(activity) ? activity.channelData.feedbackLoop.disclaimer : undefined;
15+
export default function hasFeedbackLoop(activity: WebChatActivity): activity is FeedbackActivity {
16+
return safeParse(activityWithFeedbackLoopSchema, activity).success;
17+
}

0 commit comments

Comments
 (0)