Skip to content

Commit e9375b7

Browse files
committed
Better middleware array check
1 parent ff5054e commit e9375b7

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

packages/api/src/middleware/private/templateMiddleware.check.test.tsx

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11
import templateMiddleware from './templateMiddleware';
22

3+
test('should warn if middleware is not an array of function', () => {
4+
const warn = jest.fn();
5+
const template = templateMiddleware('Check');
6+
7+
jest.spyOn(console, 'warn').mockImplementation(warn);
8+
9+
template.extractMiddleware(1 as any);
10+
11+
expect(warn).toHaveBeenCalledTimes(1);
12+
expect(warn).toHaveBeenNthCalledWith(1, expect.stringContaining('must be an array of function'));
13+
});
14+
315
test('should warn if middleware did not return function', () => {
416
const warn = jest.fn();
517
const template = templateMiddleware('Check');

packages/api/src/middleware/private/templateMiddleware.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function templateMiddleware<Request = any, Props extends {} = EmptyObject>(name:
2828
return factory;
2929
};
3030

31-
const warnInvalid = warnOnce(`"${name}" prop is invalid`);
31+
const warnInvalid = warnOnce(`"${name}" middleware prop is must be an array of function`);
3232

3333
const extractMiddleware = (
3434
middleware: readonly MiddlewareWithInit<ComponentMiddleware<unknown, unknown>, unknown>[] | undefined

0 commit comments

Comments
 (0)