Skip to content

Commit f5618d2

Browse files
committed
Add comment
1 parent 05a542e commit f5618d2

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

tsup.base.config.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,14 @@ const baseConfig: Options & { target: Target[] } = {
1717
...(npm_package_version ? { npm_package_version } : {})
1818
},
1919
esbuildOptions: options => {
20+
// esbuild don't touch AMD but it also don't remove AMD glue code.
21+
// Some of our packages prefers AMD over CJS via UMD and it also use anonymous modules.
22+
// This combination conflict with RequireJS if it present in the system.
23+
// We are removing AMD glue code manually, just like how Rollup does.
24+
// Read more at https://github.com/evanw/esbuild/issues/1348.
25+
// Also https://github.com/rollup/plugins/blob/e1a5ef99f1578eb38a8c87563cb9651db228f3bd/packages/commonjs/src/transform-commonjs.js#L328.
26+
// Test case at /__tests__/html2/hosting/requirejs.html.
2027
options.define = options.define || {};
21-
2228
options.define.define = 'undefined';
2329
options.define['define.amd'] = 'undefined';
2430

0 commit comments

Comments
 (0)